Bug 92408 - [chromium] Refactor the computation of size of resampled bitmaps for drawImage and drawPattern.
Summary: [chromium] Refactor the computation of size of resampled bitmaps for drawImag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 11:40 PDT by Stephen White
Modified: 2012-07-30 10:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2012-07-26 11:55 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2012-07-26 11:58 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (414.98 KB, application/zip)
2012-07-26 13:20 PDT, WebKit Review Bot 		no flags Details
Patch (4.81 KB, patch)
2012-07-26 13:42 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (4.87 KB, patch)
2012-07-30 07:26 PDT, Stephen White 		enne: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (466.24 KB, application/zip)
2012-07-30 10:00 PDT, WebKit Review Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-07-26 11:40:15 PDT 
[chromium] Refactor the computation of size of resampled bitmaps for drawImage and drawPattern.
Comment 1 Stephen White 2012-07-26 11:55:14 PDT 
Created attachment 154710 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-26 11:57:08 PDT 
Attachment 154710 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Stephen White 2012-07-26 11:58:29 PDT 
Created attachment 154712 [details]
Patch
Comment 4 WebKit Review Bot 2012-07-26 13:20:30 PDT 
Comment on attachment 154712 [details]
Patch

Attachment 154712 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13368024

New failing tests:
fast/gradients/background-clipped.html
Comment 5 WebKit Review Bot 2012-07-26 13:20:33 PDT 
Created attachment 154730 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Stephen White 2012-07-26 13:42:05 PDT 
Created attachment 154741 [details]
Patch
Comment 7 Stephen White 2012-07-30 07:26:17 PDT 
Created attachment 155287 [details]
Patch
Comment 8 Stephen White 2012-07-30 08:40:12 PDT 
kbr or enne for review?
Comment 9 Adrienne Walker 2012-07-30 08:57:37 PDT 
Comment on attachment 155287 [details]
Patch

R=me.
Comment 10 WebKit Review Bot 2012-07-30 10:00:03 PDT 
Comment on attachment 155287 [details]
Patch

Attachment 155287 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13392378

New failing tests:
platform/chromium/compositing/accelerated-drawing/svg-filters.html
platform/chromium/compositing/accelerated-drawing/alpha.html
Comment 11 WebKit Review Bot 2012-07-30 10:00:07 PDT 
Created attachment 155307 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 12 Stephen White 2012-07-30 10:19:28 PDT 
These tests seem to be crashing randomly on the bots (probably http://trac.webkit.org/changeset/123987).  Landing manually.
Comment 13 Stephen White 2012-07-30 10:22:54 PDT 
Committed r124042: <http://trac.webkit.org/changeset/124042>