Bug 92404 - [BlackBerry] Add timing logs to SelectionHandler.
Summary: [BlackBerry] Add timing logs to SelectionHandler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 11:23 PDT by Mike Fenton
Modified: 2012-07-26 13:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2012-07-26 11:33 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff
Fix style in patch. (4.72 KB, patch)
2012-07-26 11:45 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-07-26 11:23:24 PDT
SSIA.
Comment 1 Mike Fenton 2012-07-26 11:33:15 PDT
Created attachment 154704 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-26 11:36:34 PDT
Attachment 154704 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h:24:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mike Fenton 2012-07-26 11:45:21 PDT
Created attachment 154706 [details]
Fix style in patch.
Comment 4 Rob Buis 2012-07-26 11:51:02 PDT
Comment on attachment 154706 [details]
Fix style in patch.

Looks good.
Comment 5 WebKit Review Bot 2012-07-26 13:20:02 PDT
Comment on attachment 154706 [details]
Fix style in patch.

Clearing flags on attachment: 154706

Committed r123787: <http://trac.webkit.org/changeset/123787>
Comment 6 WebKit Review Bot 2012-07-26 13:20:05 PDT
All reviewed patches have been landed.  Closing bug.