Bug 92389 – Outline is always painted on the first table row regardless of the row it's set on

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

Created attachment 154669 [details]
Test case: both outlines shouldn't be on the first row

This is a super simple bug. We don't account for the row's position when painting the outline and thus always paint it on the first row, regardless of where it is set up. See the attached test case.

The issue is in RenderTableRow::paintOutlineForRowIfNeeded that doesn't move the |paintOffset| accordingly.

[Pravin D]

(In reply to comment #0)
> Created an attachment (id=154669) [details]
> Test case: both outlines shouldn't be on the first row
> 
> This is a super simple bug. We don't account for the row's position when painting the outline and thus always paint it on the first row, regardless of where it is set up. See the attached test case.
> 
> The issue is in RenderTableRow::paintOutlineForRowIfNeeded that doesn't move the |paintOffset| accordingly.
> 

Super super simple bug I guess... They have properly handled Table sections n forgot the rows...

[Pravin D]

Created attachment 154716 [details]
Patch

[Pravin D]

Created attachment 154720 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 154720 [details]
Patch

OK.  LGTM.

[Pravin D]

(In reply to comment #4)
> (From update of attachment 154720 [details])
> OK.  LGTM.
> 

Thnks... :)

[Pravin D]

Hope the pixel test do not cause any problem...

[WebKit Review Bot]

Comment on attachment 154720 [details]
Patch

Clearing flags on attachment: 154720

Committed r123793: <http://trac.webkit.org/changeset/123793>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Julien Chaffraix]

Comment on attachment 154720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154720&action=review

> LayoutTests/fast/table/table-row-outline-paint.html:17
> +<table>

Descriptions and expectations for maintainers are always nice, even in comments or not visible.

> LayoutTests/platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt:1
> +layer at (0,0) size 800x600

The baseline was wrongly added for Chromium only. Without anything tied to a platform, it's a pity it wasn't put next to the test case and shared by all platforms. Hopefully webkit-patch rebaseline will do the right thing here.

[Andrew Wilson]

Added more updated expectations in http://trac.webkit.org/changeset/123812 - please review to make sure they are correct.

[Shezan Baig]

*** Bug 94007 has been marked as a duplicate of this bug. ***