Bug 92385 - Web Inspector: element tag disappears after editing
Summary: Web Inspector: element tag disappears after editing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 08:28 PDT by Andrey Kosyakov
Modified: 2012-07-30 02:25 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.88 KB, patch)
2012-07-26 10:09 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-07-26 08:28:26 PDT
0. Navigate to http://webkit.org
1. Open Web Inspector
2. Switch to Elements panel
3. Double-click on any element (e.g. <div id="title" ...>")
4. Edit attribute (e.g. add an attribute)
5. Press Enter
6. Observe that the element tag is replaced with whitespace.
7. Hover mouse over where the tag used to be -- observe it's visible again.
Comment 1 Pavel Feldman 2012-07-26 10:09:28 PDT
Created attachment 154678 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-07-27 00:35:04 PDT
Comment on attachment 154678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154678&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2041
> +        var hidePanelWhileUpdating = this._recentlyModifiedNodes.length > 10;

Please extract a const here.
Comment 3 WebKit Review Bot 2012-07-30 02:25:38 PDT
Comment on attachment 154678 [details]
Patch

Clearing flags on attachment: 154678

Committed r124007: <http://trac.webkit.org/changeset/124007>
Comment 4 WebKit Review Bot 2012-07-30 02:25:42 PDT
All reviewed patches have been landed.  Closing bug.