Bug 92375 - [WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
Summary: [WebGL] Align contents of drawbuffer-test.html layout test with the one in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nayan Kumar K
URL:
Keywords:
Depends on: 91976
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 06:09 PDT by Nayan Kumar K
Modified: 2012-07-27 23:56 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (16.67 KB, patch)
2012-07-26 06:18 PDT, Nayan Kumar K
no flags Details | Formatted Diff | Diff
Reworked patch (16.67 KB, patch)
2012-07-26 22:08 PDT, Nayan Kumar K
no flags Details | Formatted Diff | Diff
Rebased patch (13.01 KB, patch)
2012-07-27 00:33 PDT, Nayan Kumar K
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nayan Kumar K 2012-07-26 06:09:42 PDT
As per the discussion in https://bugs.webkit.org/show_bug.cgi?id=91976, contents of Layouttests/canvas/webgl/drawbuffer-test.html need to be aligned with conformance/canvas/drawingbuffer-test.html in the WebGL conformance suite.
Comment 1 Nayan Kumar K 2012-07-26 06:18:00 PDT
Created attachment 154636 [details]
Proposed patch
Comment 2 Kenneth Russell 2012-07-26 16:13:26 PDT
Comment on attachment 154636 [details]
Proposed patch

Thanks for doing this. I'm clearing the r? bit for now. Please update the patch once https://bugs.webkit.org/show_bug.cgi?id=91976 lands.
Comment 3 Nayan Kumar K 2012-07-26 22:08:43 PDT
Created attachment 154841 [details]
Reworked patch
Comment 4 Nayan Kumar K 2012-07-27 00:33:01 PDT
Created attachment 154865 [details]
Rebased patch
Comment 5 Kenneth Russell 2012-07-27 14:14:11 PDT
Comment on attachment 154865 [details]
Rebased patch

Fantastic. Thanks. r=me
Comment 6 WebKit Review Bot 2012-07-27 23:56:06 PDT
Comment on attachment 154865 [details]
Rebased patch

Clearing flags on attachment: 154865

Committed r123956: <http://trac.webkit.org/changeset/123956>
Comment 7 WebKit Review Bot 2012-07-27 23:56:09 PDT
All reviewed patches have been landed.  Closing bug.