RESOLVED FIXED 92373
Web Inspector: Move formatting support from JavaScriptSource to UISourceCode. 
https://bugs.webkit.org/show_bug.cgi?id=92373
Summary Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
Vsevolod Vlasov
Reported 2012-07-26 05:54:14 PDT
Patch to follow
Attachments
Patch (26.80 KB, patch)
2012-07-26 07:24 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-07-26 05:54:59 PDT
This change will allow us to support CSS formatting and simplify UISourceCode code.
Vsevolod Vlasov
Comment 2 2012-07-26 07:24:26 PDT
Created attachment 154649 [details] Patch
Pavel Feldman
Comment 3 2012-07-26 08:59:04 PDT
Comment on attachment 154649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154649&action=review > Source/WebCore/inspector/front-end/JavaScriptSource.js:51 > uiLocationToRawLocation: function(lineNumber, columnNumber) I don't think you need this method. > Source/WebCore/inspector/front-end/Script.js:223 > + uiLocation: function() This looks like a great self-contained change. > Source/WebCore/inspector/front-end/ScriptFormatter.js:35 > +WebInspector.Formatter = function(workerURL) I don't think we should imply that the formatter is implemented using worker. > Source/WebCore/inspector/front-end/UISourceCode.js:411 > + uiLocationToRawLocation: function(lineNumber, columnNumber) You should move it back.
Vsevolod Vlasov
Comment 4 2012-07-27 01:50:57 PDT
Committed r123852: <http://trac.webkit.org/changeset/123852>
Note You need to log in before you can comment on or make changes to this bug.