Bug 92373 - Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
Summary: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
Depends on:
Reported: 2012-07-26 05:54 PDT by Vsevolod Vlasov
Modified: 2012-07-27 01:50 PDT (History)
10 users (show)

See Also:

Patch (26.80 KB, patch)
2012-07-26 07:24 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-07-26 05:54:14 PDT
Patch to follow
Comment 1 Vsevolod Vlasov 2012-07-26 05:54:59 PDT
This change will allow us to support CSS formatting and simplify UISourceCode code.
Comment 2 Vsevolod Vlasov 2012-07-26 07:24:26 PDT
Created attachment 154649 [details]
Comment 3 Pavel Feldman 2012-07-26 08:59:04 PDT
Comment on attachment 154649 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=154649&action=review

> Source/WebCore/inspector/front-end/JavaScriptSource.js:51
>      uiLocationToRawLocation: function(lineNumber, columnNumber)

I don't think you need this method.

> Source/WebCore/inspector/front-end/Script.js:223
> +    uiLocation: function()

This looks like a great self-contained change.

> Source/WebCore/inspector/front-end/ScriptFormatter.js:35
> +WebInspector.Formatter = function(workerURL)

I don't think we should imply that the formatter is implemented using worker.

> Source/WebCore/inspector/front-end/UISourceCode.js:411
> +    uiLocationToRawLocation: function(lineNumber, columnNumber)

You should move it back.
Comment 4 Vsevolod Vlasov 2012-07-27 01:50:57 PDT
Committed r123852: <http://trac.webkit.org/changeset/123852>