Bug 92371 - [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
Summary: [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 92505
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-26 05:45 PDT by Patrick R. Gansterer
Modified: 2013-05-09 16:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.62 KB, patch)
2012-07-26 05:49 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (20.40 KB, patch)
2012-07-27 09:05 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (6.60 KB, patch)
2012-07-27 09:10 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2013-05-09 15:11 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-26 05:45:27 PDT 
[WIN][DRT] Replace pthread_mutex_t with WTF::Mutex
Comment 1 Patrick R. Gansterer 2012-07-26 05:49:18 PDT 
Created attachment 154625 [details]
Patch
Comment 2 Patrick R. Gansterer 2012-07-27 09:05:49 PDT 
Created attachment 154968 [details]
Patch
Comment 3 Patrick R. Gansterer 2012-07-27 09:10:55 PDT 
Created attachment 154970 [details]
Patch
Comment 4 Brent Fulgham 2013-05-08 23:02:07 PDT 
Comment on attachment 154970 [details]
Patch

This looks great!  Once the blocking patch clears you should land this.
Comment 5 Patrick R. Gansterer 2013-05-09 15:11:27 PDT 
Created attachment 201286 [details]
Patch
Comment 6 Brent Fulgham 2013-05-09 16:13:17 PDT 
Comment on attachment 201286 [details]
Patch

We probably need to add it to DumpRenderTree.vcxproj.filters as well, but go ahead and land it.  The project should self-heal.
Comment 7 WebKit Commit Bot 2013-05-09 16:45:52 PDT 
The commit-queue encountered the following flaky tests while processing attachment 201286 [details]:

svg/as-image/img-relative-height.html bug 114140 (author: zimmermann@kde.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2013-05-09 16:47:14 PDT 
Comment on attachment 201286 [details]
Patch

Clearing flags on attachment: 201286

Committed r149855: <http://trac.webkit.org/changeset/149855>
Comment 9 WebKit Commit Bot 2013-05-09 16:47:16 PDT 
All reviewed patches have been landed.  Closing bug.