Bug 92363 – [Tests] Add compositing/graphicslayer-display-none.html

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Dongseong Hwang]

This test checks whether the GraphicsLayer is removed after 'style.display'
for an element sets 'None'.

[Dongseong Hwang]

Created attachment 154604 [details]
Patch

[Dongseong Hwang]

When 'style.display' for an element sets 'none', the render object of the element is removed, so the render layer and the graphics layer of the element is removed too.
I can not find tests to check this behavior, so I made this test.

[WebKit Review Bot]

Comment on attachment 154604 [details]
Patch

Attachment 154604 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13340711

New failing tests:
compositing/graphicslayer-display-none.html

[WebKit Review Bot]

Created attachment 154623 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Dongseong Hwang]

Created attachment 154831 [details]
Patch

[Eric Seidel (no email)]

When was this a problem?  What bug is this testing?

[James Robinson]

I can't think of any bugs this would have caught in the compositor bindings code and I don't that this test provides much value.

[Simon Fraser (smfr)]

(In reply to comment #7)
> I can't think of any bugs this would have caught in the compositor bindings code and I don't that this test provides much value.

Agreed.

[Eric Seidel (no email)]

Thanks for the patch, but based on above comments looks like this test isn't needed at this time!

[Dongseong Hwang]

Thank you for your comments.

I submitted this patch because I thought increasing test coverage is better.
When I surveyed how 'display: none' and 'visibility: hidden' affect accelerated compositing, I found various visibility tests (i.e. compositing/visibility/visibility-image-layers-dynamic.html) but there was no 'display: none' test. So, I made this test, which tests 'display:none', similar to visibility-image-layers-dynamic.html, which tests 'visibility'.

[Eric Seidel (no email)]

Comment on attachment 154831 [details]
Patch

Cleared review? from attachment 154831 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).