Bug 92349 - [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
Summary: [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is cra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 92350 (view as bug list)
Depends on:
Blocks: 92072
  Show dependency tree / graph
 
Reported: 2012-07-26 01:28 PDT by Chris Dumez
Modified: 2012-07-26 03:08 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2012-07-26 01:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-26 01:28:04 PDT 
strdup has been replaced by eina stringsharing in:
http://trac.webkit.org/changeset/123604

Unfortunately, this change causes webintents/web-intents-obj-constructor.html to crash now.
Comment 1 Chris Dumez 2012-07-26 01:32:47 PDT 
Looks like DumpRenderTreeChrome::onFrameIntentNew() was not updated accordingly to use einastringshare_del() instead of free(). I'm preparing a fix now.
Comment 2 Chris Dumez 2012-07-26 01:34:26 PDT 
*** Bug 92350 has been marked as a duplicate of this bug. ***
Comment 3 Chris Dumez 2012-07-26 01:43:07 PDT 
Created attachment 154577 [details]
Patch
Comment 4 Gyuyoung Kim 2012-07-26 01:48:31 PDT 
Comment on attachment 154577 [details]
Patch

Looks fine. Thanks.
Comment 5 Kentaro Hara 2012-07-26 01:49:31 PDT 
Comment on attachment 154577 [details]
Patch

Looks OK.
Comment 6 WebKit Review Bot 2012-07-26 03:08:02 PDT 
Comment on attachment 154577 [details]
Patch

Clearing flags on attachment: 154577

Committed r123723: <http://trac.webkit.org/changeset/123723>
Comment 7 WebKit Review Bot 2012-07-26 03:08:09 PDT 
All reviewed patches have been landed.  Closing bug.