Bug 92332 – Gather the duplicated timer code into CachedResource.

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Dongseong Hwang]

When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.

[Dongseong Hwang]

Created attachment 154537 [details]
Patch

[Dongseong Hwang]

This is follow-up patch of Bug 91733.

Geoffrey said "I'd like to see more code sharing for destroying decoded data on a timer.", and I agreed.

Therefore, I did this patch.

[Dongseong Hwang]

Created attachment 154547 [details]
Patch

[Dongseong Hwang]

Changed the Changlog to add "Internal review by".

[Kwang Yul Seo]

Comment on attachment 154547 [details]
Patch

Clearing flags on attachment: 154547

Committed r123808: <http://trac.webkit.org/changeset/123808>

[Kwang Yul Seo]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 92443

[Dongseong Hwang]

I'm sorry for my carelessness.

CachedScript::script() calls m_decodedDataDeletionTimer.startOneShot(0).

 466 void CachedResource::decodedDataDeletionTimerFired(Timer<CachedResource>*)
 467 {
 468     ASSERT(!hasClients());
 469     destroyDecodedData();
 470 }

So, ASSERTION can be failed.

I'll remove ASSERT and kseo will commit again.

[Kwang Yul Seo]

Created attachment 154815 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 154815 [details]
Patch for landing

Clearing flags on attachment: 154815

Committed r123848: <http://trac.webkit.org/changeset/123848>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.