RESOLVED DUPLICATE of bug 92310 92329
XML parser should use parserSetAttributes instead of setAttributeNS 
https://bugs.webkit.org/show_bug.cgi?id=92329
Summary XML parser should use parserSetAttributes instead of setAttributeNS
Ryosuke Niwa
Reported 2012-07-25 19:07:38 PDT
It's not safe to use setAttributeNS because it fires a bunch of events. Of course, the element had not been inserted in to the document at the point so we're not firing events. Nonetheless, it's very error prone.
Attachments
Refactoring (10.57 KB, patch)
2012-07-25 19:16 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-07-25 19:16:43 PDT
Created attachment 154525 [details] Refactoring
Ryosuke Niwa
Comment 2 2012-07-25 19:23:33 PDT
Comment on attachment 154525 [details] Refactoring View in context: https://bugs.webkit.org/attachment.cgi?id=154525&action=review > Source/WebCore/ChangeLog:12 > + There should be no user observable behavior change. Actually, I lied. This will fix the bug 92310... merging the bugs.
Ryosuke Niwa
Comment 3 2012-07-25 19:23:47 PDT
*** This bug has been marked as a duplicate of bug 92310 ***
Lucas Forschler
Comment 4 2019-02-06 09:02:41 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.