Bug 92329 - XML parser should use parserSetAttributes instead of setAttributeNS
Summary: XML parser should use parserSetAttributes instead of setAttributeNS
Status: RESOLVED DUPLICATE of bug 92310
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 19:07 PDT by Ryosuke Niwa
Modified: 2019-02-06 09:02 PST (History)
4 users (show)

See Also:


Attachments
Refactoring (10.57 KB, patch)
2012-07-25 19:16 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-07-25 19:07:38 PDT
It's not safe to use setAttributeNS because it fires a bunch of events. Of course, the element had not been inserted in to the document at the point so we're not firing events. Nonetheless, it's very error prone.
Comment 1 Ryosuke Niwa 2012-07-25 19:16:43 PDT
Created attachment 154525 [details]
Refactoring
Comment 2 Ryosuke Niwa 2012-07-25 19:23:33 PDT
Comment on attachment 154525 [details]
Refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=154525&action=review

> Source/WebCore/ChangeLog:12
> +        There should be no user observable behavior change.

Actually, I lied. This will fix the bug 92310... merging the bugs.
Comment 3 Ryosuke Niwa 2012-07-25 19:23:47 PDT

*** This bug has been marked as a duplicate of bug 92310 ***
Comment 4 Lucas Forschler 2019-02-06 09:02:41 PST
Mass moving XML DOM bugs to the "DOM" Component.