RESOLVED FIXED 92326
Web Inspector: ExtensionView constructor shouldn't take parent argument 
https://bugs.webkit.org/show_bug.cgi?id=92326
Summary Web Inspector: ExtensionView constructor shouldn't take parent argument
Jan Keromnes
Reported 2012-07-25 18:13:09 PDT
ExtensionView's constructor takes a parent argument and directly calls `this.show(parent)` at the end of the constructor. This is problematic if you're creating and ExtensionView but you don't want to show it right away or you don't know about its parent element yet. The correct behavior should be the same as for View objects: do not take `parent` as a constructor argument, wait for a call to `extensionView.show(parent)` whenever needed.
Attachments
Patch (3.44 KB, patch)
2012-07-25 18:59 PDT, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-07-25 18:59:59 PDT
Created attachment 154517 [details] Patch
Andrey Kosyakov
Comment 2 2012-07-26 06:12:02 PDT
Comment on attachment 154517 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-07-26 09:12:53 PDT
Comment on attachment 154517 [details] Patch Clearing flags on attachment: 154517 Committed r123753: <http://trac.webkit.org/changeset/123753>
WebKit Review Bot
Comment 4 2012-07-26 09:12:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.