Bug 92324 – flex-wrap: wrap not wrapping for % sized items in column flow

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Scott Miles]

Created attachment 154502 [details]
flex-wrap samples highlighting failing configuration

%-sized flex items not wrapping under flex-flow: column wrap (they do in fact wrap under flex-flow: row wrap)

[Ojan Vafai]

Yup, definitely a bug.

[Tony Chang]

Created attachment 154786 [details]
Patch

[WebKit Review Bot]

Comment on attachment 154786 [details]
Patch

Attachment 154786 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13369269

New failing tests:
css3/flexbox/percentage-heights.html

[WebKit Review Bot]

Created attachment 154861 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Tony Chang]

Created attachment 154994 [details]
Patch for landing

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 154786 [details])
> Attachment 154786 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/13369269
> 
> New failing tests:
> css3/flexbox/percentage-heights.html

I'm dumb. I had changed the height/width properties of the flexbox to min-height/min-width because I was testing if I needed to handle that.  I forgot to change it back when I uploaded the diff.

I'll let the commit queue land this to verify that the new test is correct.

[WebKit Review Bot]

Comment on attachment 154994 [details]
Patch for landing

Clearing flags on attachment: 154994

Committed r123909: <http://trac.webkit.org/changeset/123909>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.