RESOLVED FIXED 92307
Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml 
https://bugs.webkit.org/show_bug.cgi?id=92307
Summary Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml
Ryosuke Niwa
Reported 2012-07-25 15:17:08 PDT
Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml
Attachments
Patch (12.05 KB, patch)
2012-07-25 15:30 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-07-25 15:30:03 PDT
Created attachment 154462 [details] Patch
Tony Chang
Comment 2 2012-07-25 15:58:48 PDT
Comment on attachment 154462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154462&action=review > LayoutTests/editing/pasteboard/resources/paste-noscript-content.html:13 > -<iframe id="iframe1" src="javascript:sayHello()" style="width: 200px; height: 100px; background-color:#cee;"></iframe> > +<iframe id="iframe1" src="javascript:alert('hello')" style="width: 200px; height: 100px; background-color:#cee;"></iframe> Wasn't this testing that sayHello isn't in the same context? Maybe change it to something like alert(window.sayHello ? 'FAILED' : 'PASSED: sayHello not found').
Ryosuke Niwa
Comment 3 2012-07-25 16:00:39 PDT
Comment on attachment 154462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154462&action=review >> LayoutTests/editing/pasteboard/resources/paste-noscript-content.html:13 >> +<iframe id="iframe1" src="javascript:alert('hello')" style="width: 200px; height: 100px; background-color:#cee;"></iframe> > > Wasn't this testing that sayHello isn't in the same context? Maybe change it to something like alert(window.sayHello ? 'FAILED' : 'PASSED: sayHello not found'). No. The test simply checks that this attribute value is stripped. So the reference error you see is generated the first time this document is loaded in the iframe, not when it's pasted.
Ryosuke Niwa
Comment 4 2012-07-25 16:41:58 PDT
Committed r123678: <http://trac.webkit.org/changeset/123678>
Note You need to log in before you can comment on or make changes to this bug.