RESOLVED FIXED 92306
"webkit-patch upload" should strip colors from patch if necessary 
https://bugs.webkit.org/show_bug.cgi?id=92306
Summary "webkit-patch upload" should strip colors from patch if necessary
WebKit Review Bot
Reported 2012-07-25 14:48:01 PDT
"webkit-patch upload" should strip colors from patch if necessary Requested by rafaelbrandao on #webkit.
Attachments
Patch (1.58 KB, patch)
2012-07-25 22:34 PDT, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2012-07-25 22:34:51 PDT
Created attachment 154543 [details] Patch
Rafael Brandao
Comment 2 2012-07-25 22:42:53 PDT
I will add unit tests for this if necessary. It was spotted on bug 91242 where the first two patches are not readable if you click on "Formatted Diff" on bugzilla. If you remove "&action=prettypatch" and check the raw, you'll see it has the colors on it. I was using "git config color.diff" with "always" instead of "auto".
Rafael Brandao
Comment 3 2012-07-26 07:43:01 PDT
Comment on attachment 154543 [details] Patch I accept suggestions to where I should put tests for this, if it's needed. The downside is that I would have to change git config local settings before running such tests and restore those values afterwards.
Adam Barth
Comment 4 2012-07-26 08:34:21 PDT
Comment on attachment 154543 [details] Patch Crazy. Can you run Tools/Script/tests-webkitpy to make sure this doesn't break any unit tests?
Rafael Brandao
Comment 5 2012-07-27 14:13:39 PDT
Comment on attachment 154543 [details] Patch Double checked, it looks like no harm was done. Thanks!
WebKit Review Bot
Comment 6 2012-07-27 15:10:45 PDT
Comment on attachment 154543 [details] Patch Clearing flags on attachment: 154543 Committed r123924: <http://trac.webkit.org/changeset/123924>
WebKit Review Bot
Comment 7 2012-07-27 15:10:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.