Bug 92306 - "webkit-patch upload" should strip colors from patch if necessary
Summary: "webkit-patch upload" should strip colors from patch if necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Brandao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 14:48 PDT by WebKit Review Bot
Modified: 2012-07-27 15:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2012-07-25 22:34 PDT, Rafael Brandao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-07-25 14:48:01 PDT 
"webkit-patch upload" should strip colors from patch if necessary
Requested by rafaelbrandao on #webkit.
Comment 1 Rafael Brandao 2012-07-25 22:34:51 PDT 
Created attachment 154543 [details]
Patch
Comment 2 Rafael Brandao 2012-07-25 22:42:53 PDT 
I will add unit tests for this if necessary.

It was spotted on bug 91242 where the first two patches are not readable if you click on "Formatted Diff" on bugzilla. If you remove "&action=prettypatch" and check the raw, you'll see it has the colors on it.

I was using "git config color.diff" with "always" instead of "auto".
Comment 3 Rafael Brandao 2012-07-26 07:43:01 PDT 
Comment on attachment 154543 [details]
Patch

I accept suggestions to where I should put tests for this, if it's needed. The downside is that I would have to change git config local settings before running such tests and restore those values afterwards.
Comment 4 Adam Barth 2012-07-26 08:34:21 PDT 
Comment on attachment 154543 [details]
Patch

Crazy.  Can you run Tools/Script/tests-webkitpy to make sure this doesn't break any unit tests?
Comment 5 Rafael Brandao 2012-07-27 14:13:39 PDT 
Comment on attachment 154543 [details]
Patch

Double checked, it looks like no harm was done. Thanks!
Comment 6 WebKit Review Bot 2012-07-27 15:10:45 PDT 
Comment on attachment 154543 [details]
Patch

Clearing flags on attachment: 154543

Committed r123924: <http://trac.webkit.org/changeset/123924>
Comment 7 WebKit Review Bot 2012-07-27 15:10:50 PDT 
All reviewed patches have been landed.  Closing bug.