"webkit-patch upload" should strip colors from patch if necessary Requested by rafaelbrandao on #webkit.
Created attachment 154543 [details] Patch
I will add unit tests for this if necessary. It was spotted on bug 91242 where the first two patches are not readable if you click on "Formatted Diff" on bugzilla. If you remove "&action=prettypatch" and check the raw, you'll see it has the colors on it. I was using "git config color.diff" with "always" instead of "auto".
Comment on attachment 154543 [details] Patch I accept suggestions to where I should put tests for this, if it's needed. The downside is that I would have to change git config local settings before running such tests and restore those values afterwards.
Comment on attachment 154543 [details] Patch Crazy. Can you run Tools/Script/tests-webkitpy to make sure this doesn't break any unit tests?
Comment on attachment 154543 [details] Patch Double checked, it looks like no harm was done. Thanks!
Comment on attachment 154543 [details] Patch Clearing flags on attachment: 154543 Committed r123924: <http://trac.webkit.org/changeset/123924>
All reviewed patches have been landed. Closing bug.