Bug 92286 - Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
Summary: Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 13:17 PDT by Patrick R. Gansterer
Modified: 2012-08-01 13:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (15.35 KB, patch)
2012-07-25 13:22 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (15.72 KB, patch)
2012-07-25 13:33 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (17.16 KB, patch)
2012-07-30 15:16 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (18.95 KB, patch)
2012-07-31 13:14 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (19.07 KB, patch)
2012-08-01 06:58 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-25 13:17:11 PDT
Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
Comment 1 Patrick R. Gansterer 2012-07-25 13:22:13 PDT
Created attachment 154424 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-25 13:25:42 PDT
Attachment 154424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1
Source/WebCore/html/FTPDirectoryDocument.cpp:233:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/FTPDirectoryDocument.cpp:233:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-07-25 13:27:50 PDT
Comment on attachment 154424 [details]
Patch

Attachment 154424 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13350352
Comment 4 Patrick R. Gansterer 2012-07-25 13:33:10 PDT
Created attachment 154425 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-25 13:35:13 PDT
Attachment 154425 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Patrick R. Gansterer 2012-07-30 15:16:23 PDT
Created attachment 155379 [details]
Patch
Comment 7 WebKit Review Bot 2012-07-30 15:19:05 PDT
Attachment 155379 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Build Bot 2012-07-30 20:54:48 PDT
Comment on attachment 155379 [details]
Patch

Attachment 155379 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13401270
Comment 9 Patrick R. Gansterer 2012-07-31 13:14:22 PDT
Created attachment 155616 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-31 13:16:58 PDT
Attachment 155616 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Patrick R. Gansterer 2012-08-01 06:58:55 PDT
Created attachment 155802 [details]
Patch
Comment 12 WebKit Review Bot 2012-08-01 07:03:12 PDT
Attachment 155802 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/FTPDirectoryDocument.cpp:234:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Geoffrey Garen 2012-08-01 12:05:30 PDT
Comment on attachment 155802 [details]
Patch

r=me
Comment 14 WebKit Review Bot 2012-08-01 13:49:44 PDT
Comment on attachment 155802 [details]
Patch

Clearing flags on attachment: 155802

Committed r124365: <http://trac.webkit.org/changeset/124365>
Comment 15 WebKit Review Bot 2012-08-01 13:49:50 PDT
All reviewed patches have been landed.  Closing bug.