Bug 92277 - [chromium] move EventSender into TestRunner.a
Summary: [chromium] move EventSender into TestRunner.a
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 92256
Blocks: 91308
  Show dependency tree / graph
 
Reported: 2012-07-25 12:23 PDT by jochen
Modified: 2012-07-31 06:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (118.92 KB, patch)
2012-07-25 12:26 PDT, jochen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-02 (410.59 KB, application/zip)
2012-07-25 15:15 PDT, WebKit Review Bot 		no flags Details
Archive of layout-test-results from gce-cq-02 (388.94 KB, application/zip)
2012-07-25 16:59 PDT, WebKit Review Bot 		no flags Details
Patch (118.11 KB, patch)
2012-07-31 04:38 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (117.07 KB, patch)
2012-07-31 04:41 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-07-25 12:23:40 PDT 
EventSender doesn't depend on WebViewHost anymore, so it can go into TestRunner
Comment 1 jochen 2012-07-25 12:26:18 PDT 
Created attachment 154416 [details]
Patch
Comment 2 jochen 2012-07-25 12:27:12 PDT 
the patch depends on https://bugs.webkit.org/show_bug.cgi?id=92256 which is currently in the CQ
Comment 3 WebKit Review Bot 2012-07-25 15:15:17 PDT 
Comment on attachment 154416 [details]
Patch

Rejecting attachment 154416 [details] from commit-queue.

New failing tests:
plugins/keyboard-events.html
Full output: http://queues.webkit.org/results/13345375
Comment 4 WebKit Review Bot 2012-07-25 15:15:20 PDT 
Created attachment 154458 [details]
Archive of layout-test-results from gce-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 5 WebKit Review Bot 2012-07-25 16:59:35 PDT 
Comment on attachment 154416 [details]
Patch

Rejecting attachment 154416 [details] from commit-queue.

New failing tests:
plugins/keyboard-events.html
Full output: http://queues.webkit.org/results/13346455
Comment 6 WebKit Review Bot 2012-07-25 16:59:38 PDT 
Created attachment 154490 [details]
Archive of layout-test-results from gce-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 jochen 2012-07-31 04:38:46 PDT 
Created attachment 155493 [details]
Patch
Comment 8 jochen 2012-07-31 04:41:30 PDT 
Created attachment 155494 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-07-31 06:02:56 PDT 
Comment on attachment 155494 [details]
Patch for landing

Clearing flags on attachment: 155494

Committed r124195: <http://trac.webkit.org/changeset/124195>
Comment 10 WebKit Review Bot 2012-07-31 06:03:00 PDT 
All reviewed patches have been landed.  Closing bug.