Bug 92276 – fix test in beginLayerClippedToImage to check for immutability if we're going to do a shallow-copy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike Reed]

fix test in beginLayerClippedToImage to check for immutability if we're going to do a shallow-copy

[Mike Reed]

Created attachment 154414 [details]
Patch

[Stephen White]

Comment on attachment 154414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154414&action=review

Please clean up the ChangeLog.

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

You'll need to delete this line, or replace it with what it asks for.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:292
> +    else {
> +        // We need to make a deep-copy of the pixels themselves, so they don't
> +        // change on us between now and when we want to apply them in restore()
> +        bitmap->copyTo(&m_state->m_imageBufferClip, SkBitmap::kARGB_8888_Config);

If we need this to work on the GPU at some point, we should probably try a deepCopyTo() first.

[Mike Reed]

Created attachment 154417 [details]
Patch

[Mike Reed]

update CL comments

[Stephen White]

Comment on attachment 154417 [details]
Patch

OK, thanks for the cleanup.  r=me

[WebKit Review Bot]

Comment on attachment 154417 [details]
Patch

Clearing flags on attachment: 154417

Committed r123665: <http://trac.webkit.org/changeset/123665>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.