Bug 92265 - Web Inspector: SASS source mapping straw man (behind experiment)
Summary: Web Inspector: SASS source mapping straw man (behind experiment)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 10:14 PDT by Pavel Feldman
Modified: 2012-07-26 10:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (24.40 KB, patch)
2012-07-25 10:17 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-07-25 10:14:25 PDT
This change introduces SASS mapping support (behind the experiment).
Comment 1 Pavel Feldman 2012-07-25 10:17:05 PDT
Created attachment 154382 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-07-25 13:18:25 PDT
Comment on attachment 154382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:51
> +        function populateFrame(frame)

We seem to have a few similar hand-written traversals - might warrant a visitor...

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:83
> +            var regex = /@media\s\-sass\-debug\-info{filename{font-family:([^}]+)}line{font-family:\\[0]+([^}]*)}}/i;

"[0]" does not need the square brackets around '0' (if I'm reading it correctly as a single-character class).

> Source/WebCore/inspector/front-end/ScriptsPanel.js:-472
> -

seems like a stray change
Comment 3 Vsevolod Vlasov 2012-07-26 09:13:25 PDT
Comment on attachment 154382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:98
> +                var rawLocation = resource.url + ":" + (lineNumber + 1);

Please use another name (e.g. rawLocationString or rawLocationId) for this variable as it is not a RawLocation.

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:128
> +        return new WebInspector.CSSLocation(uiSourceCode.contentURL() || "", lineNumber);

Please add a FIXME: comment saying this is a stub implementation
Comment 4 Pavel Feldman 2012-07-26 10:25:26 PDT
Committed r123768: <http://trac.webkit.org/changeset/123768>