As per the WebIDL spec IDL shouldn't have int attributes but long instead.
Created attachment 154372 [details] patch ArrayBuffer spec url http://www.khronos.org/registry/typedarray/specs/latest/#5 No new tests added as this shouldn't cause any regression.
Thanks abarth, as per comment https://bugs.webkit.org/show_bug.cgi?id=92181#c14 I will replace all int to "unsigned long" in one patch here with changes bug title below are the files to be chaged. ./dom/Touch.idl: readonly attribute int webkitRadiusX; ./dom/Touch.idl: readonly attribute int webkitRadiusY; ./dom/WebKitNamedFlow.idl: readonly attribute int firstEmptyRegionIndex; ./html/canvas/WebGLActiveInfo.idl: readonly attribute int size; ./html/canvas/WebGLActiveInfo.idl: readonly attribute unsigned int type; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int rangeMin; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int rangeMax; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int precision; ./page/WebKitAnimation.idl: readonly attribute [Custom] int iterationCount;
It's not clear that they should all be "unsigned long". You need to check the specs for each one to see what the correct type is.
Created attachment 154415 [details] updated_patch (In reply to comment #3) > It's not clear that they should all be "unsigned long". You need to check the specs for each one to see what the correct type is. Yes not all, only those are "unsinged int" should be repalced with "unsigned long" else for "int" with "long". ArrayBuffer.idl: http://www.khronos.org/registry/typedarray/specs/latest/#5 //Spec says should be unsinged long Touch.idl: http://dvcs.w3.org/hg/webevents/raw-file/tip/touchevents.html#idl-def-Touch WebKitNamedFlow.idl: http://www.w3.org/TR/css3-regions/#dom-named-flow-first-empty-region-index WebGLActiveInfo.idl: http://www.khronos.org/registry/webgl/specs/latest/#5.11 WebGLShaderPrecisionFormat.idl: http://www.khronos.org/registry/webgl/specs/latest/#5.12 WebKitAnimation.idl: http://www.w3.org/TR/css3-animations/#animation-iteration-count
Comment on attachment 154415 [details] updated_patch Rejecting attachment 154415 [details] from commit-queue. rgf748@motorola.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 154415 [details] updated_patch Clearing flags on attachment: 154415 Committed r123705: <http://trac.webkit.org/changeset/123705>
All reviewed patches have been landed. Closing bug.