Bug 92259 – Web Inspector: add memory reporting routine to StyleResolver

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Memory consumed by StyleResolver should be accounted as part of the CSS component.

[Yury Semikhatsky]

Created attachment 154369 [details]
Patch

[Early Warning System Bot]

Comment on attachment 154369 [details]
Patch

Attachment 154369 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13348275

[Yury Semikhatsky]

Created attachment 154374 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 154374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review

> Source/WebCore/css/StyleResolver.cpp:2516
> +        info->addInstrumentedVector(*it->second);

I'd expect that you report the key too.

> Source/WebCore/css/StyleResolver.cpp:5659
> +    // FIXME: move this to a place where it would be called only once?
> +    info.addInstrumentedMember(defaultStyle);
> +    info.addInstrumentedMember(defaultQuirksStyle);
> +    info.addInstrumentedMember(defaultPrintStyle);
> +    info.addInstrumentedMember(defaultViewSourceStyle);

What about other statics

static StyleSheetContents* simpleDefaultStyleSheet;
static StyleSheetContents* defaultStyleSheet;
static StyleSheetContents* quirksStyleSheet;
static StyleSheetContents* svgStyleSheet;
static StyleSheetContents* mathMLStyleSheet;
static StyleSheetContents* mediaControlsStyleSheet;
static StyleSheetContents* fullscreenStyleSheet;

[Yury Semikhatsky]

(In reply to comment #4)
> (From update of attachment 154374 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review
> 
> What about other statics
> 
> static StyleSheetContents* simpleDefaultStyleSheet;
> static StyleSheetContents* defaultStyleSheet;
> static StyleSheetContents* quirksStyleSheet;
> static StyleSheetContents* svgStyleSheet;
> static StyleSheetContents* mathMLStyleSheet;
> static StyleSheetContents* mediaControlsStyleSheet;
> static StyleSheetContents* fullscreenStyleSheet;

StyleSheetContents is not instrumented yet. I'm going to take care of it in another patch.

[Ilya Tikhonovsky]

Comment on attachment 154374 [details]
Patch

lgtm

[WebKit Review Bot]

Comment on attachment 154374 [details]
Patch

Clearing flags on attachment: 154374

Committed r123726: <http://trac.webkit.org/changeset/123726>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.