Pass all file chooser settings to clients.
cc
Created attachment 154322 [details] patch
Comment on attachment 154322 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review > Source/WebKit/blackberry/Api/WebPageClient.h:171 > + virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0; Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays?
(In reply to comment #3) > (From update of attachment 154322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review > > > Source/WebKit/blackberry/Api/WebPageClient.h:171 > > + virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0; > > Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays? I admit this method have too many parameters :( SharedArray is a very simple template class in the platform. The array size cannot be deduced from SharedArray, since it does not store any information about the size of array. I will look into if SharedArray can be extend so that we can get array size from it.
Created attachment 155467 [details] updated patch
Comment on attachment 155467 [details] updated patch LGTM.
Comment on attachment 155467 [details] updated patch Clearing flags on attachment: 155467 Committed r124285: <http://trac.webkit.org/changeset/124285>
All reviewed patches have been landed. Closing bug.