RESOLVED FIXED 92237
[BlackBerry] Pass all file chooser settings to clients 
https://bugs.webkit.org/show_bug.cgi?id=92237
Summary [BlackBerry] Pass all file chooser settings to clients
Robin Cao
Reported 2012-07-25 03:56:12 PDT
Pass all file chooser settings to clients.
Attachments
patch (4.79 KB, patch)
2012-07-25 04:14 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
updated patch (3.62 KB, patch)
2012-07-31 01:59 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-07-25 04:11:32 PDT
cc
Robin Cao
Comment 2 2012-07-25 04:14:30 PDT
Created attachment 154322 [details] patch
Rob Buis
Comment 3 2012-07-25 15:13:50 PDT
Comment on attachment 154322 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review > Source/WebKit/blackberry/Api/WebPageClient.h:171 > + virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0; Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays?
Robin Cao
Comment 4 2012-07-25 19:27:43 PDT
(In reply to comment #3) > (From update of attachment 154322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review > > > Source/WebKit/blackberry/Api/WebPageClient.h:171 > > + virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0; > > Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays? I admit this method have too many parameters :( SharedArray is a very simple template class in the platform. The array size cannot be deduced from SharedArray, since it does not store any information about the size of array. I will look into if SharedArray can be extend so that we can get array size from it.
Robin Cao
Comment 5 2012-07-31 01:59:41 PDT
Created attachment 155467 [details] updated patch
Rob Buis
Comment 6 2012-07-31 04:20:12 PDT
Comment on attachment 155467 [details] updated patch LGTM.
WebKit Review Bot
Comment 7 2012-07-31 19:39:49 PDT
Comment on attachment 155467 [details] updated patch Clearing flags on attachment: 155467 Committed r124285: <http://trac.webkit.org/changeset/124285>
WebKit Review Bot
Comment 8 2012-07-31 19:39:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.