Bug 92237 - [BlackBerry] Pass all file chooser settings to clients
Summary: [BlackBerry] Pass all file chooser settings to clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 03:56 PDT by Robin Cao
Modified: 2012-07-31 19:39 PDT (History)
5 users (show)

See Also:


Attachments
patch (4.79 KB, patch)
2012-07-25 04:14 PDT, Robin Cao
no flags Details | Formatted Diff | Diff
updated patch (3.62 KB, patch)
2012-07-31 01:59 PDT, Robin Cao
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cao 2012-07-25 03:56:12 PDT
Pass all file chooser settings to clients.
Comment 1 Robin Cao 2012-07-25 04:11:32 PDT
cc
Comment 2 Robin Cao 2012-07-25 04:14:30 PDT
Created attachment 154322 [details]
patch
Comment 3 Rob Buis 2012-07-25 15:13:50 PDT
Comment on attachment 154322 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review

> Source/WebKit/blackberry/Api/WebPageClient.h:171
> +    virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0;

Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays?
Comment 4 Robin Cao 2012-07-25 19:27:43 PDT
(In reply to comment #3)
> (From update of attachment 154322 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review
> 
> > Source/WebKit/blackberry/Api/WebPageClient.h:171
> > +    virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0;
> 
> Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays?

I admit this method have too many parameters :(

SharedArray is a very simple template class in the platform. The array size cannot be deduced from SharedArray, since it does not store any information about the size of array.

I will look into if SharedArray can be extend so that we can get array size from it.
Comment 5 Robin Cao 2012-07-31 01:59:41 PDT
Created attachment 155467 [details]
updated patch
Comment 6 Rob Buis 2012-07-31 04:20:12 PDT
Comment on attachment 155467 [details]
updated patch

LGTM.
Comment 7 WebKit Review Bot 2012-07-31 19:39:49 PDT
Comment on attachment 155467 [details]
updated patch

Clearing flags on attachment: 155467

Committed r124285: <http://trac.webkit.org/changeset/124285>
Comment 8 WebKit Review Bot 2012-07-31 19:39:53 PDT
All reviewed patches have been landed.  Closing bug.