Bug 92236 – [Chromium][Win] <progress> animation on RTL direction is reverse

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

This upstreams http://code.google.com/p/chromium/issues/detail?id=138247

[Hajime Morrita]

Created attachment 154319 [details]
Patch

[Kent Tamura]

Comment on attachment 154319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154319&action=review

> Source/WebCore/rendering/RenderThemeChromiumLinux.cpp:361
> +    saveTransformIfNecessary(o, i, rect);
>      PlatformSupport::paintThemePart(i.context, PlatformSupport::PartProgressBar, getWebThemeState(this, o), rect, &extraParams);

The function name 'saveTransformIfNecessary' isn't good for code readability.
A reader can't understand what is done in saveTransformIfNecessary.

Also, we had better use RAII idiom.

[Hajime Morrita]

Created attachment 154518 [details]
Patch

[Hajime Morrita]

Thanks for the review, Kent-san, I updated the patch which employs a scoping class.
Could you take another look?

[Kent Tamura]

Comment on attachment 154518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154518&action=review

> Source/WebCore/rendering/RenderThemeChromiumSkia.h:166
> +            ~DirectionFlippingScope();
> +        private:

nit: Need a blank line before private:.

[Hajime Morrita]

Created attachment 154521 [details]
Patch for landing

[Hajime Morrita]

Thanks for the quick response!

(In reply to comment #5)
> (From update of attachment 154518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154518&action=review
> 
> > Source/WebCore/rendering/RenderThemeChromiumSkia.h:166
> > +            ~DirectionFlippingScope();
> > +        private:
> 
> nit: Need a blank line before private:.
Landing updated pach.

[WebKit Review Bot]

Comment on attachment 154521 [details]
Patch for landing

Clearing flags on attachment: 154521

Committed r123706: <http://trac.webkit.org/changeset/123706>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.