Bug 92236 - [Chromium][Win] <progress> animation on RTL direction is reverse
Summary: [Chromium][Win] <progress> animation on RTL direction is reverse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 03:49 PDT by Hajime Morrita
Modified: 2012-07-25 20:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.63 KB, patch)
2012-07-25 04:02 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2012-07-25 19:01 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (8.04 KB, patch)
2012-07-25 19:08 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-07-25 03:49:06 PDT
This upstreams http://code.google.com/p/chromium/issues/detail?id=138247
Comment 1 Hajime Morrita 2012-07-25 04:02:22 PDT
Created attachment 154319 [details]
Patch
Comment 2 Kent Tamura 2012-07-25 04:40:34 PDT
Comment on attachment 154319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154319&action=review

> Source/WebCore/rendering/RenderThemeChromiumLinux.cpp:361
> +    saveTransformIfNecessary(o, i, rect);
>      PlatformSupport::paintThemePart(i.context, PlatformSupport::PartProgressBar, getWebThemeState(this, o), rect, &extraParams);

The function name 'saveTransformIfNecessary' isn't good for code readability.
A reader can't understand what is done in saveTransformIfNecessary.

Also, we had better use RAII idiom.
Comment 3 Hajime Morrita 2012-07-25 19:01:02 PDT
Created attachment 154518 [details]
Patch
Comment 4 Hajime Morrita 2012-07-25 19:02:05 PDT
Thanks for the review, Kent-san, I updated the patch which employs a scoping class.
Could you take another look?
Comment 5 Kent Tamura 2012-07-25 19:04:16 PDT
Comment on attachment 154518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154518&action=review

> Source/WebCore/rendering/RenderThemeChromiumSkia.h:166
> +            ~DirectionFlippingScope();
> +        private:

nit: Need a blank line before private:.
Comment 6 Hajime Morrita 2012-07-25 19:08:24 PDT
Created attachment 154521 [details]
Patch for landing
Comment 7 Hajime Morrita 2012-07-25 19:09:04 PDT
Thanks for the quick response!

(In reply to comment #5)
> (From update of attachment 154518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154518&action=review
> 
> > Source/WebCore/rendering/RenderThemeChromiumSkia.h:166
> > +            ~DirectionFlippingScope();
> > +        private:
> 
> nit: Need a blank line before private:.
Landing updated pach.
Comment 8 WebKit Review Bot 2012-07-25 20:27:13 PDT
Comment on attachment 154521 [details]
Patch for landing

Clearing flags on attachment: 154521

Committed r123706: <http://trac.webkit.org/changeset/123706>
Comment 9 WebKit Review Bot 2012-07-25 20:27:17 PDT
All reviewed patches have been landed.  Closing bug.