Bug 92228 - [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
Summary: [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 88303
  Show dependency treegraph
Reported: 2012-07-25 01:19 PDT by Chris Dumez
Modified: 2012-07-27 13:10 PDT (History)
4 users (show)

See Also:

Patch (10.02 KB, patch)
2012-07-25 04:01 PDT, Chris Dumez
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (10.05 KB, patch)
2012-07-25 04:53 PDT, Chris Dumez
andersca: review-
andersca: commit-queue-
Details | Formatted Diff | Diff
Patch (10.88 KB, patch)
2012-07-25 11:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.44 KB, patch)
2012-07-25 13:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-25 01:19:13 PDT
The following web intents test rely on LayoutTestController.deliverWebIntent():

The tests is now failing on WebKit2 WTR because LayoutTestController.deliverWebIntent() is undefined.
Comment 1 Chris Dumez 2012-07-25 04:01:56 PDT
Created attachment 154318 [details]
Comment 2 Early Warning System Bot 2012-07-25 04:46:25 PDT
Comment on attachment 154318 [details]

Attachment 154318 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13361015
Comment 3 Chris Dumez 2012-07-25 04:53:22 PDT
Created attachment 154326 [details]

Should fix build on other ports than EFL.
Comment 4 Anders Carlsson 2012-07-25 10:32:09 PDT
Comment on attachment 154326 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=154326&action=review

> Source/WebKit2/UIProcess/API/C/WKIntentData.cpp:48
> +WKIntentDataRef WKIntentDataCreate(WKIntentData wkIntentData)

Please make WKIntentDataCreate take the action, type and data as individual parameters instead of using a struct.

> Source/WebKit2/UIProcess/API/C/WKIntentData.h:40
> +struct WKIntentData {
> +    WKStringRef action;
> +    WKStringRef type;
> +    WKSerializedScriptValueRef data;
> +};
> +typedef struct WKIntentData WKIntentData;

Having a struct with public members like this is bad from a memory management standpoint.
Comment 5 Chris Dumez 2012-07-25 11:49:46 PDT
Created attachment 154408 [details]

Use a WKDictionary instead of a structure as initialization argument, as discussed with andersca on IRC. I'm trying to avoid using distinct function arguments because we may choose to pass more initialization parameters in the future. Using a dictionary is more easily extensible and would not break API compatibility.
Comment 6 Chris Dumez 2012-07-25 13:41:05 PDT
Created attachment 154430 [details]

Rebase on master.
Comment 7 WebKit Review Bot 2012-07-27 13:10:35 PDT
Comment on attachment 154430 [details]

Clearing flags on attachment: 154430

Committed r123911: <http://trac.webkit.org/changeset/123911>
Comment 8 WebKit Review Bot 2012-07-27 13:10:40 PDT
All reviewed patches have been landed.  Closing bug.