Bug 92228 – [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

The following web intents test rely on LayoutTestController.deliverWebIntent():
  webintents/web-intents-delivery.html

The tests is now failing on WebKit2 WTR because LayoutTestController.deliverWebIntent() is undefined.

[Chris Dumez]

Created attachment 154318 [details]
Patch

[Early Warning System Bot]

Comment on attachment 154318 [details]
Patch

Attachment 154318 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13361015

[Chris Dumez]

Created attachment 154326 [details]
Patch

Should fix build on other ports than EFL.

[Anders Carlsson]

Comment on attachment 154326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154326&action=review

> Source/WebKit2/UIProcess/API/C/WKIntentData.cpp:48
> +WKIntentDataRef WKIntentDataCreate(WKIntentData wkIntentData)

Please make WKIntentDataCreate take the action, type and data as individual parameters instead of using a struct.

> Source/WebKit2/UIProcess/API/C/WKIntentData.h:40
> +struct WKIntentData {
> +    WKStringRef action;
> +    WKStringRef type;
> +    WKSerializedScriptValueRef data;
> +};
> +typedef struct WKIntentData WKIntentData;

Having a struct with public members like this is bad from a memory management standpoint.

[Chris Dumez]

Created attachment 154408 [details]
Patch

Use a WKDictionary instead of a structure as initialization argument, as discussed with andersca on IRC. I'm trying to avoid using distinct function arguments because we may choose to pass more initialization parameters in the future. Using a dictionary is more easily extensible and would not break API compatibility.

[Chris Dumez]

Created attachment 154430 [details]
Patch

Rebase on master.

[WebKit Review Bot]

Comment on attachment 154430 [details]
Patch

Clearing flags on attachment: 154430

Committed r123911: <http://trac.webkit.org/changeset/123911>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.