Bug 92226 – Initialize QualifiedName's strings from the read only data segment

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Benjamin Poulain]

Initialize QualifiedName's strings from the read only data segment

[Benjamin Poulain]

Created attachment 154285 [details]
Patch

[Early Warning System Bot]

Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13343162

[Gyuyoung Kim]

Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13343163

[Early Warning System Bot]

Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13348151

[Benjamin Poulain]

First draft for comments.

I don't have time now but I plan to make the following changes:
-move the two createQualifiedName() in a separate file in the WebCore namespace
-share them between all XYZNames::init()


Possibly in a separate patch:
To kill the code bloat, modify the code to initialize everything in a loop instead of doing it flat.

[WebKit Review Bot]

Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13347163

[Benjamin Poulain]

Created attachment 154455 [details]
Patch

[Anders Carlsson]

Comment on attachment 154455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154455&action=review

> Source/WTF/wtf/text/AtomicString.cpp:118
> +struct HashTranslatorCharBuffer {

For hash translators we treat HashTranslator as a suffix, so this should be CharBufferHashTranslator.

[Benjamin Poulain]

Comment on attachment 154455 [details]
Patch

Clearing flags on attachment: 154455

Committed r123689: <http://trac.webkit.org/changeset/123689>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.