Bug 92226 - Initialize QualifiedName's strings from the read only data segment
Summary: Initialize QualifiedName's strings from the read only data segment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 00:50 PDT by Benjamin Poulain
Modified: 2012-07-25 18:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.35 KB, patch)
2012-07-25 01:06 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (15.18 KB, patch)
2012-07-25 15:04 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-07-25 00:50:11 PDT
Initialize QualifiedName's strings from the read only data segment
Comment 1 Benjamin Poulain 2012-07-25 01:06:16 PDT
Created attachment 154285 [details]
Patch
Comment 2 Early Warning System Bot 2012-07-25 01:19:55 PDT
Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13343162
Comment 3 Gyuyoung Kim 2012-07-25 01:21:25 PDT
Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13343163
Comment 4 Early Warning System Bot 2012-07-25 01:24:59 PDT
Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13348151
Comment 5 Benjamin Poulain 2012-07-25 01:25:58 PDT
First draft for comments.

I don't have time now but I plan to make the following changes:
-move the two createQualifiedName() in a separate file in the WebCore namespace
-share them between all XYZNames::init()


Possibly in a separate patch:
To kill the code bloat, modify the code to initialize everything in a loop instead of doing it flat.
Comment 6 WebKit Review Bot 2012-07-25 01:51:14 PDT
Comment on attachment 154285 [details]
Patch

Attachment 154285 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13347163
Comment 7 Benjamin Poulain 2012-07-25 15:04:02 PDT
Created attachment 154455 [details]
Patch
Comment 8 Anders Carlsson 2012-07-25 16:59:57 PDT
Comment on attachment 154455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154455&action=review

> Source/WTF/wtf/text/AtomicString.cpp:118
> +struct HashTranslatorCharBuffer {

For hash translators we treat HashTranslator as a suffix, so this should be CharBufferHashTranslator.
Comment 9 Benjamin Poulain 2012-07-25 18:05:34 PDT
Comment on attachment 154455 [details]
Patch

Clearing flags on attachment: 154455

Committed r123689: <http://trac.webkit.org/changeset/123689>
Comment 10 Benjamin Poulain 2012-07-25 18:05:37 PDT
All reviewed patches have been landed.  Closing bug.