Bug 92225 - Web Inspector: Improve ObjectPropertiesSection UI by adding a tooltip for the value.
Summary: Web Inspector: Improve ObjectPropertiesSection UI by adding a tooltip for the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-25 00:48 PDT by Vsevolod Vlasov
Modified: 2012-07-25 07:55 PDT (History)
12 users (show)

See Also:


Attachments
Patch (15.08 KB, patch)
2012-07-25 00:59 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (298.17 KB, application/zip)
2012-07-25 01:48 PDT, WebKit Review Bot
no flags Details
Patch (1.66 KB, patch)
2012-07-25 06:28 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-07-25 00:48:35 PDT
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-07-25 00:59:04 PDT
Created attachment 154284 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-25 01:48:02 PDT
Comment on attachment 154284 [details]
Patch

Attachment 154284 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13347171

New failing tests:
inspector/console/console-big-array.html
Comment 3 WebKit Review Bot 2012-07-25 01:48:06 PDT
Created attachment 154291 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Pavel Feldman 2012-07-25 02:27:02 PDT
Comment on attachment 154284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154284&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:349
> +            InspectorFrontendHost.copyText(this.property.value.description);

What's wrong with selecting the value and copying it?
Comment 5 Vsevolod Vlasov 2012-07-25 06:28:14 PDT
Created attachment 154337 [details]
Patch
Comment 6 WebKit Review Bot 2012-07-25 07:55:25 PDT
Comment on attachment 154337 [details]
Patch

Clearing flags on attachment: 154337

Committed r123616: <http://trac.webkit.org/changeset/123616>
Comment 7 WebKit Review Bot 2012-07-25 07:55:30 PDT
All reviewed patches have been landed.  Closing bug.