Bug 92219 – [EFL][DRT] fast/loader/stop-provisional-loads.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Joone Hur]

We need to add the ability to tell DRT to call ewk_frame_stop inside of a didStartProvisionalLoadForFrame signal handler.
For more details, please take a look at https://trac.webkit.org/changeset/34972.

[Joone Hur]

Created attachment 154279 [details]
Patch

[Chris Dumez]

Comment on attachment 154279 [details]
Patch

As long as it does not cause regressions for other tests, LGTM. Maybe you should use [DRT] keyword in bug title.

[Gyuyoung Kim]

Comment on attachment 154279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review

As we talk on irc, please consider WK2 layout test as well.

> Tools/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule.

[Chris Dumez]

Comment on attachment 154279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review

>> Tools/ChangeLog:10
>> +        Reviewed by NOBODY (OOPS!).
> 
> Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule.

Right, sorry I missed that.

[Joone Hur]

Created attachment 155440 [details]
Patch

[Joone Hur]

@Christophe, @Gyuyoung: I've moved the description below *Reviewed by NOBODY* and checked that this test case already passes in WK2 test.

Thanks for the review.

[Kenneth Rohde Christiansen]

Comment on attachment 155440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155440&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:690
> +        const String frameName(DumpRenderTreeSupportEfl::suitableDRTFrameName(frame));

Btw Qt is getting rid for DumpRenderTreeSupportQt for a separate library. You should have a look

[WebKit Review Bot]

Comment on attachment 155440 [details]
Patch

Clearing flags on attachment: 155440

Committed r124599: <http://trac.webkit.org/changeset/124599>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.