Bug 92217 – A validation bubble should not be modifiable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

As the other elements in UserAgentShadowDOM, validation bubble should not be modifiable.

[Shinya Kawanaka]

It's hard to write a test... The validation box disappears when I try to edit.
How should we try to test this..?

[Kent Tamura]

(In reply to comment #1)
> It's hard to write a test... The validation box disappears when I try to edit.
> How should we try to test this..?

Settings::setValidationMessageTimerMagnification(0) ?
It's 0 in DRT.

[Shinya Kawanaka]

(In reply to comment #2)
> (In reply to comment #1)
> > It's hard to write a test... The validation box disappears when I try to edit.
> > How should we try to test this..?
> 
> Settings::setValidationMessageTimerMagnification(0) ?
> It's 0 in DRT.

Thanks. I could write a test.

[Shinya Kawanaka]

Created attachment 154296 [details]
Patch

[Kent Tamura]

Comment on attachment 154296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154296&action=review

> Source/WebCore/ChangeLog:19
> +        (::-webkit-validation-bubble):
> +        (::-webkit-validation-bubble-message):
> +        (::-webkit-validation-bubble-text-block):
> +        (::-webkit-validation-bubble-heading):
> +        (::-webkit-validation-bubble-arrow):
> +        (::-webkit-validation-bubble-arrow-clipper):

Write what you changed and the reason.

> LayoutTests/ChangeLog:9
> +        * fast/forms/validation-user-modify.html: Added.

The test file name should start with validation-message- to follow other existing tests.

> LayoutTests/fast/forms/validation-user-modify.html:31
> +if (window.testRunner)
> +    testRunner.waitUntilDone();

should be replaced with jsTestIsAsync = true;.

> LayoutTests/fast/forms/validation-user-modify.html:52
> +    if (window.testRunner)
> +        testRunner.notifyDone();

should be replaced with finishJSTest();.

[Shinya Kawanaka]

Created attachment 154303 [details]
Patch

[Kent Tamura]

Comment on attachment 154303 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 154303 [details]
Patch

Clearing flags on attachment: 154303

Committed r123598: <http://trac.webkit.org/changeset/123598>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Roger Fong]

Hello, 
I think that the test should involve some sort of focus check to make sure that when you're deleting things you're actually in the validation bubble.

If the validation bubble fails to show up (or somehow the test 'misses' the validation bubble and tries to delete from nothing) the test will falsely pass.