RESOLVED FIXED 92214
Remove anonymous namespace and make functions static. 
https://bugs.webkit.org/show_bug.cgi?id=92214
Summary Remove anonymous namespace and make functions static.
Kwang Yul Seo
Reported 2012-07-24 23:26:45 PDT
Mark functions as static instead of enclosing them in anonymous namespaces. One exception to this rule is when a function is passed as a template argument. In this case, the function must have an external linkage.
Attachments
Patch (17.25 KB, patch)
2012-07-24 23:28 PDT, Kwang Yul Seo 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-07-24 23:28:50 PDT
Created attachment 154266 [details] Patch
Kwang Yul Seo
Comment 2 2012-07-24 23:30:00 PDT
Adam mentioned this cleanup idea in https://bugs.webkit.org/show_bug.cgi?id=92079#c9
Adam Barth
Comment 3 2012-07-24 23:43:31 PDT
Comment on attachment 154266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154266&action=review > Source/WebCore/html/parser/create-html-entity-table:-112 > -namespace { I would actually leave this one. There are a ton of symbols in here that would be good to hide from the linker.
Kwang Yul Seo
Comment 4 2012-07-24 23:45:34 PDT
(In reply to comment #3) > (From update of attachment 154266 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154266&action=review > > > Source/WebCore/html/parser/create-html-entity-table:-112 > > -namespace { > > I would actually leave this one. There are a ton of symbols in here that would be good to hide from the linker. Okay. I will change it before I land the patch.
Kwang Yul Seo
Comment 5 2012-07-24 23:53:06 PDT
Committed r123581: <http://trac.webkit.org/changeset/123581>
Note You need to log in before you can comment on or make changes to this bug.