Mark functions as static instead of enclosing them in anonymous namespaces. One exception to this rule is when a function is passed as a template argument. In this case, the function must have an external linkage.
Created attachment 154266 [details] Patch
Adam mentioned this cleanup idea in https://bugs.webkit.org/show_bug.cgi?id=92079#c9
Comment on attachment 154266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154266&action=review > Source/WebCore/html/parser/create-html-entity-table:-112 > -namespace { I would actually leave this one. There are a ton of symbols in here that would be good to hide from the linker.
(In reply to comment #3) > (From update of attachment 154266 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154266&action=review > > > Source/WebCore/html/parser/create-html-entity-table:-112 > > -namespace { > > I would actually leave this one. There are a ton of symbols in here that would be good to hide from the linker. Okay. I will change it before I land the patch.
Committed r123581: <http://trac.webkit.org/changeset/123581>