Bug 92213 – [EFL][WK2] Implement the inspector for WebKitTestRunner

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Seokju Kwon]

Implementation of WebInspectorProxyEfl for WebkitTestRunner
 And Web Inspector resources installation.

[Seokju Kwon]

Created attachment 154297 [details]
Patch

[Seokju Kwon]

Test Result on 2012/07/23 

LayoutTest/inspector
=> Results: 260/262 tests passed (99.2%)
=> Tests to be fixed (38):
      2 text diff mismatch       ( 5.3%)
     36 skipped                  (94.7%)
=> Tests that will only be fixed if they crash (WONTFIX) (0):
Regressions: Unexpected text diff mismatch : (2)
  inspector/extensions/extensions-panel.html = TEXT
  inspector/timeline/timeline-event-dispatch.html = TEXT

LayoutTests/http/tests/inspector
=> Results: 58/62 tests passed (93.5%)
=> Tests to be fixed (30):
      4 text diff mismatch       (13.3%)
     26 skipped                  (86.7%)
=> Tests that will only be fixed if they crash (WONTFIX) (0):
Regressions: Unexpected text diff mismatch : (4)
  http/tests/inspector/appcache/appcache-iframe-manifests.html = TEXT
  http/tests/inspector/appcache/appcache-swap.html = TEXT
  http/tests/inspector/network/network-sidebar-width.html = TEXT
  http/tests/inspector/resource-main-cookies.php = TEXT

LayoutTests/http/tests/inspector-enabled/
=> Results: 10/10 tests passed (100.0%)
=> Tests to be fixed (0):
=> Tests that will only be fixed if they crash (WONTFIX) (0):

[Gyuyoung Kim]

Comment on attachment 154297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154297&action=review

> Source/WebKit2/ChangeLog:8
> +        Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner

Missing '.' at the end of sentence.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:86
> +#elif PLATFORM(EFL)

I think we don't need to have independent #elif because variable names are same.

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:94
> +    if (access(inspectorFilesPath.utf8().data(), R_OK)) // On success, zero is returned

Unneeded comment. Everyone know zero is returned on success.

[Seokju Kwon]

Created attachment 154514 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 154514 [details]
Patch

Looks good to me now.

[Seokju Kwon]

(In reply to comment #5)
> (From update of attachment 154514 [details])
> Looks good to me now.

Thanks for reviewing.
I will move tests to be fixed to TestExpectations with bug id.

[Ryosuke Niwa]

Comment on attachment 154514 [details]
Patch

rs=me.

[WebKit Review Bot]

Comment on attachment 154514 [details]
Patch

Clearing flags on attachment: 154514

Committed r123703: <http://trac.webkit.org/changeset/123703>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.