WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92213
[EFL][WK2] Implement the inspector for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92213
Summary
[EFL][WK2] Implement the inspector for WebKitTestRunner
Seokju Kwon
Reported
2012-07-24 23:12:52 PDT
Implementation of WebInspectorProxyEfl for WebkitTestRunner And Web Inspector resources installation.
Attachments
Patch
(6.37 KB, patch)
2012-07-25 02:06 PDT
,
Seokju Kwon
no flags
Details
Formatted Diff
Diff
Patch
(6.32 KB, patch)
2012-07-25 18:56 PDT
,
Seokju Kwon
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Seokju Kwon
Comment 1
2012-07-25 02:06:53 PDT
Created
attachment 154297
[details]
Patch
Seokju Kwon
Comment 2
2012-07-25 17:04:00 PDT
Test Result on 2012/07/23 LayoutTest/inspector => Results: 260/262 tests passed (99.2%) => Tests to be fixed (38): 2 text diff mismatch ( 5.3%) 36 skipped (94.7%) => Tests that will only be fixed if they crash (WONTFIX) (0): Regressions: Unexpected text diff mismatch : (2) inspector/extensions/extensions-panel.html = TEXT inspector/timeline/timeline-event-dispatch.html = TEXT LayoutTests/http/tests/inspector => Results: 58/62 tests passed (93.5%) => Tests to be fixed (30): 4 text diff mismatch (13.3%) 26 skipped (86.7%) => Tests that will only be fixed if they crash (WONTFIX) (0): Regressions: Unexpected text diff mismatch : (4) http/tests/inspector/appcache/appcache-iframe-manifests.html = TEXT http/tests/inspector/appcache/appcache-swap.html = TEXT http/tests/inspector/network/network-sidebar-width.html = TEXT http/tests/inspector/resource-main-cookies.php = TEXT LayoutTests/http/tests/inspector-enabled/ => Results: 10/10 tests passed (100.0%) => Tests to be fixed (0): => Tests that will only be fixed if they crash (WONTFIX) (0):
Gyuyoung Kim
Comment 3
2012-07-25 18:02:48 PDT
Comment on
attachment 154297
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=154297&action=review
> Source/WebKit2/ChangeLog:8 > + Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner
Missing '.' at the end of sentence.
> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:86 > +#elif PLATFORM(EFL)
I think we don't need to have independent #elif because variable names are same.
> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:94 > + if (access(inspectorFilesPath.utf8().data(), R_OK)) // On success, zero is returned
Unneeded comment. Everyone know zero is returned on success.
Seokju Kwon
Comment 4
2012-07-25 18:56:09 PDT
Created
attachment 154514
[details]
Patch
Gyuyoung Kim
Comment 5
2012-07-25 19:14:11 PDT
Comment on
attachment 154514
[details]
Patch Looks good to me now.
Seokju Kwon
Comment 6
2012-07-25 19:30:20 PDT
(In reply to
comment #5
)
> (From update of
attachment 154514
[details]
) > Looks good to me now.
Thanks for reviewing. I will move tests to be fixed to TestExpectations with bug id.
Ryosuke Niwa
Comment 7
2012-07-25 19:34:11 PDT
Comment on
attachment 154514
[details]
Patch rs=me.
WebKit Review Bot
Comment 8
2012-07-25 20:02:40 PDT
Comment on
attachment 154514
[details]
Patch Clearing flags on attachment: 154514 Committed
r123703
: <
http://trac.webkit.org/changeset/123703
>
WebKit Review Bot
Comment 9
2012-07-25 20:02:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug