Bug 92203 – IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: WebKit API changes to support upgradeneeded methods and events

[David Grogan]

Created attachment 154239 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[David Grogan]

Josh, could you take a look at this?

[Joshua Bell]

Comment on attachment 154239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154239&action=review

LGTM, just naming nits.

> Source/WebKit/chromium/public/WebIDBCallbacks.h:61
> +    virtual void onBlocked(long long existingVersion) { WEBKIT_ASSERT_NOT_REACHED(); }

Is there significance to calling this "existingVersion" rather than "oldVersion"?

> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:38
> +    virtual void onVersionChange(long long currentVersion, long long requestedVersion) { WEBKIT_ASSERT_NOT_REACHED(); }

Can these be "oldVersion" and "newVersion" to align with the spec properties?

[David Grogan]

Comment on attachment 154239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154239&action=review

>> Source/WebKit/chromium/public/WebIDBCallbacks.h:61
>> +    virtual void onBlocked(long long existingVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> Is there significance to calling this "existingVersion" rather than "oldVersion"?

No, thanks for catching that.

>> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:38
>> +    virtual void onVersionChange(long long currentVersion, long long requestedVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> Can these be "oldVersion" and "newVersion" to align with the spec properties?

SG.

[David Grogan]

Created attachment 154278 [details]
Patch

[David Grogan]

WebKit API reviewers, this is ready for you.

[WebKit Review Bot]

Comment on attachment 154278 [details]
Patch

Clearing flags on attachment: 154278

Committed r123710: <http://trac.webkit.org/changeset/123710>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.