Bug 92203 - IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
Summary: IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-24 21:05 PDT by David Grogan
Modified: 2012-07-25 23:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.63 KB, patch)
2012-07-24 21:13 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (6.61 KB, patch)
2012-07-25 00:12 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-07-24 21:05:39 PDT 
IndexedDB: WebKit API changes to support upgradeneeded methods and events
Comment 1 David Grogan 2012-07-24 21:13:46 PDT 
Created attachment 154239 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-24 21:15:10 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 David Grogan 2012-07-24 21:20:45 PDT 
Josh, could you take a look at this?
Comment 4 Joshua Bell 2012-07-24 22:01:28 PDT 
Comment on attachment 154239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154239&action=review

LGTM, just naming nits.

> Source/WebKit/chromium/public/WebIDBCallbacks.h:61
> +    virtual void onBlocked(long long existingVersion) { WEBKIT_ASSERT_NOT_REACHED(); }

Is there significance to calling this "existingVersion" rather than "oldVersion"?

> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:38
> +    virtual void onVersionChange(long long currentVersion, long long requestedVersion) { WEBKIT_ASSERT_NOT_REACHED(); }

Can these be "oldVersion" and "newVersion" to align with the spec properties?
Comment 5 David Grogan 2012-07-25 00:11:19 PDT 
Comment on attachment 154239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154239&action=review

>> Source/WebKit/chromium/public/WebIDBCallbacks.h:61
>> +    virtual void onBlocked(long long existingVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> Is there significance to calling this "existingVersion" rather than "oldVersion"?

No, thanks for catching that.

>> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:38
>> +    virtual void onVersionChange(long long currentVersion, long long requestedVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> Can these be "oldVersion" and "newVersion" to align with the spec properties?

SG.
Comment 6 David Grogan 2012-07-25 00:12:22 PDT 
Created attachment 154278 [details]
Patch
Comment 7 David Grogan 2012-07-25 16:02:34 PDT 
WebKit API reviewers, this is ready for you.
Comment 8 WebKit Review Bot 2012-07-25 23:37:57 PDT 
Comment on attachment 154278 [details]
Patch

Clearing flags on attachment: 154278

Committed r123710: <http://trac.webkit.org/changeset/123710>
Comment 9 WebKit Review Bot 2012-07-25 23:38:02 PDT 
All reviewed patches have been landed.  Closing bug.