Bug 92200 – The elements in Shadow DOM of input should not be modifiable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

According to Bug 65738 comment, we have the following bugs.

1. Load data:text/html,<style>input::-webkit-textfield-decoration-container { -webkit-user-modify: read-write; }</style><input type=search>
2. Focus on the search field
3. Press backward-delete key
4. Crash

Another related issue:
1. Load data:text/html,<style>input::-webkit-search-results-button { -webkit-user-modify: read-write; }</style><input type=search results=20>
2. Right-click on the magnifier button.
3. You can type into the magnifier button.

[Shinya Kawanaka]

Created attachment 154264 [details]
Patch

[Shinya Kawanaka]

Created attachment 154520 [details]
Patch

[Shinya Kawanaka]

tkent-san, could you review this?

[Kent Tamura]

Comment on attachment 154520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154520&action=review

> LayoutTests/fast/forms/input-user-modify.html:34
> +focusAndType("search", "delete");
> +focusAndType("input", "delete");

low test coverage

[Shinya Kawanaka]

Created attachment 155433 [details]
Patch

[Kent Tamura]

Comment on attachment 155433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155433&action=review

> LayoutTests/fast/forms/input-user-modify.html:42
> +    <input id="search" type="search">
> +    <input id="file" type="file">
> +    <input id="range" type="range">
> +    <input id="color" type="color">
> +    <input id="number" type="number">
> +    <input id="placeholder" type="text" placeholder="something">
> +    <input id="speech" type="text" x-webkit-speech>

We need test cases for <button>, <input type=date>, and <video controls> or <audio controls>.

> LayoutTests/fast/forms/input-user-modify.html:45
> +<pre id="console"></pre>

This is not used.

> LayoutTests/fast/forms/input-user-modify.html:69
> +var successfullyParsed = true;

This is unnecessary.

[Shinya Kawanaka]

Created attachment 155437 [details]
Patch

[Kent Tamura]

Comment on attachment 155437 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 155437 [details]
Patch

Rejecting attachment 155437 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13393880

[Shinya Kawanaka]

Created attachment 155728 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 155728 [details]
Patch for landing

Rejecting attachment 155728 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13415097

[Shinya Kawanaka]

Created attachment 155967 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 155967 [details]
Patch for landing

Clearing flags on attachment: 155967

Committed r124407: <http://trac.webkit.org/changeset/124407>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.