Bug 92195 - IndexedDB: Make db.version return an integer if appropriate
Summary: IndexedDB: Make db.version return an integer if appropriate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-24 19:23 PDT by David Grogan
Modified: 2012-07-25 17:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2012-07-24 20:16 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2012-07-24 21:18 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (1.02 MB, application/zip)
2012-07-24 22:46 PDT, WebKit Review Bot 		no flags Details
Patch (3.12 KB, patch)
2012-07-25 13:36 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-07-24 19:23:09 PDT 
IndexedDB: Make db.version return an integer if appropriate
Comment 1 David Grogan 2012-07-24 20:16:02 PDT 
Created attachment 154230 [details]
Patch
Comment 2 David Grogan 2012-07-24 20:16:41 PDT 
Josh, could you take a look at this?
Comment 3 Joshua Bell 2012-07-24 20:32:56 PDT 
Comment on attachment 154230 [details]
Patch

LGTM
Comment 4 David Grogan 2012-07-24 20:43:05 PDT 
Tony, could you review this?
Comment 5 Adam Barth 2012-07-24 21:10:30 PDT 
Comment on attachment 154230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review

> Source/WebCore/ChangeLog:9
> +        upgradeneeded API has been used.

typo: upgradeneeded
Comment 6 David Grogan 2012-07-24 21:18:59 PDT 
Created attachment 154240 [details]
Patch
Comment 7 David Grogan 2012-07-24 21:19:46 PDT 
Comment on attachment 154230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review

>> Source/WebCore/ChangeLog:9
>> +        upgradeneeded API has been used.
> 
> typo: upgradeneeded

Clarified.
Comment 8 WebKit Review Bot 2012-07-24 22:46:06 PDT 
Comment on attachment 154240 [details]
Patch

Attachment 154240 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13349105

New failing tests:
http/tests/security/script-crossorigin-loads-correctly.html
fast/loader/loadInProgress.html
fast/loader/unload-form-post-about-blank.html
Comment 9 WebKit Review Bot 2012-07-24 22:46:10 PDT 
Created attachment 154256 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 10 David Grogan 2012-07-25 13:36:44 PDT 
Created attachment 154428 [details]
Patch
Comment 11 David Grogan 2012-07-25 13:39:33 PDT 
Tony, could you review this?

The last patch had no changes, just rebased onto the latest trunk.  It looks like the interdiff capability is gone in the new bugzilla version.
Comment 12 Tony Chang 2012-07-25 15:42:01 PDT 
Comment on attachment 154428 [details]
Patch

Can you test this using === in JS?
Comment 13 David Grogan 2012-07-25 16:00:16 PDT 
(In reply to comment #12)
> (From update of attachment 154428 [details])
> Can you test this using === in JS?

Yep. It's done a couple of places in the layout tests for integer versions, e.g. https://bugs.webkit.org/attachment.cgi?id=153651&action=review#line1842.

I should have noted that this patch is a chunk broken off of that one.
Comment 14 WebKit Review Bot 2012-07-25 17:25:20 PDT 
Comment on attachment 154428 [details]
Patch

Clearing flags on attachment: 154428

Committed r123683: <http://trac.webkit.org/changeset/123683>
Comment 15 WebKit Review Bot 2012-07-25 17:25:25 PDT 
All reviewed patches have been landed.  Closing bug.