Bug 92184 – [chromium] Move renderingStats from WebView to WebWidget.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Tu]

[chromium] Move renderingStats from WebView to WebWidget.

[Dave Tu]

Created attachment 154194 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 154194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154194&action=review

> Source/WebKit/chromium/public/WebWidget.h:226
> +    // Fills in a WebRenderingStats struct containing information about the state of the compositor.
> +    // This call is relatively expensive in threaded mode as it blocks on the compositor thread.

This comment seems slightly at odds with the ChangeLog.

This patch is fine, but it would be valuable to add some more information to the ChangeLog about why we're making this change.  Maybe just an example?  Certainly not a big deal, but it can be helpful to folks reading these patches.

[WebKit Review Bot]

Comment on attachment 154194 [details]
Patch

Attachment 154194 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13345054

New failing tests:
fast/forms/range/slider-onchange-event.html
fast/forms/range/slider-mouse-events.html
fast/forms/range/slider-delete-while-dragging-thumb.html

[WebKit Review Bot]

Created attachment 154213 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 154194 [details]
Patch

Rejecting attachment 154194 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ty/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 113.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2582.

Full output: http://queues.webkit.org/results/13343075

[WebKit Review Bot]

Comment on attachment 154194 [details]
Patch

Clearing flags on attachment: 154194

Committed r123574: <http://trac.webkit.org/changeset/123574>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.