Bug 92176 – Remove unused function in InjectedBundleHitTestResult

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit2

[Changhun Kang]

coreHitTestResult() is never used. So I remove it.

[Changhun Kang]

Created attachment 154177 [details]
Patch

[Kwang Yul Seo]

ChangeLog is missing.

[Changhun Kang]

Created attachment 154185 [details]
Patch

[Kwang Yul Seo]

(In reply to comment #3)
> Created an attachment (id=154185) [details]
> Patch

ChangeLog is still missing.

[Changhun Kang]

Created attachment 154186 [details]
Patch

[Kwang Yul Seo]

Comment on attachment 154186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154186&action=review

> Source/WebKit2/ChangeLog:9
> +	No new tests because this patch just remove dead code.

Fix the indentation here.

[WebKit Review Bot]

Attachment 154186 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Changhun Kang]

Created attachment 154188 [details]
Patch

[Brady Eidson]

Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.

[Changhun Kang]

(In reply to comment #9)
> Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.

It was first appeared at 39e1fcbcf3dbb10eaa79d6364a43d781b3d9ebee(Sat Sep 25 02:32:56 2010).

But it is remained as dead code. 
WKBundleHitTestResult is API level of InjectedBundleHitTestResult. But API level does not have any match case.

Also it seems to be redundant with another member function "static PassRefPtr<InjectedBundleHitTestResult> create(const WebCore::HitTestResult&)"

Thank you for your comment
.

[Brady Eidson]

(In reply to comment #10)
> (In reply to comment #9)
> > Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.
> 
> It was first appeared at 39e1fcbcf3dbb10eaa79d6364a43d781b3d9ebee(Sat Sep 25 02:32:56 2010).
> 
> But it is remained as dead code. 
> WKBundleHitTestResult is API level of InjectedBundleHitTestResult. But API level does not have any match case.
> 
> Also it seems to be redundant with another member function "static PassRefPtr<InjectedBundleHitTestResult> create(const WebCore::HitTestResult&)"


I understand that it is dead code and unused.

My point is that we don't normally go on tiny little cleanup tasks like this.  It uses up buildbot infrastructure and reviewer time as well as causes potential merging problems for various branches and ports.

[Changhun Kang]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.
> > 
> > It was first appeared at 39e1fcbcf3dbb10eaa79d6364a43d781b3d9ebee(Sat Sep 25 02:32:56 2010).
> > 
> > But it is remained as dead code. 
> > WKBundleHitTestResult is API level of InjectedBundleHitTestResult. But API level does not have any match case.
> > 
> > Also it seems to be redundant with another member function "static PassRefPtr<InjectedBundleHitTestResult> create(const WebCore::HitTestResult&)"
> 
> 
> I understand that it is dead code and unused.
> 
> My point is that we don't normally go on tiny little cleanup tasks like this.  It uses up buildbot infrastructure and reviewer time as well as causes potential merging problems for various branches and ports.

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.
> > 
> > It was first appeared at 39e1fcbcf3dbb10eaa79d6364a43d781b3d9ebee(Sat Sep 25 02:32:56 2010).
> > 
> > But it is remained as dead code. 
> > WKBundleHitTestResult is API level of InjectedBundleHitTestResult. But API level does not have any match case.
> > 
> > Also it seems to be redundant with another member function "static PassRefPtr<InjectedBundleHitTestResult> create(const WebCore::HitTestResult&)"
> 
> 
> I understand that it is dead code and unused.
> 
> My point is that we don't normally go on tiny little cleanup tasks like this.  It uses up buildbot infrastructure and reviewer time as well as causes potential merging problems for various branches and ports.

Sorry, I'm a newbie. I'll be careful next time.

[WebKit Review Bot]

Comment on attachment 154188 [details]
Patch

Attachment 154188 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13353088

New failing tests:
animations/suspend-resume-animation-events.html
fast/forms/range/slider-mouse-events.html
fast/forms/range/slider-delete-while-dragging-thumb.html
fast/forms/range/slider-onchange-event.html

[WebKit Review Bot]

Created attachment 154251 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Adam Barth]

Comment on attachment 154188 [details]
Patch

Cleared review? from attachment 154188 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).