Bug 92143 - Web Inspector: simplify handling of status bar items
Summary: Web Inspector: simplify handling of status bar items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-24 11:01 PDT by Andrey Kosyakov
Modified: 2012-07-26 10:56 PDT (History)
10 users (show)

See Also:


Attachments
Patch (26.08 KB, patch)
2012-07-24 11:06 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (26.22 KB, patch)
2012-07-25 09:41 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (26.40 KB, patch)
2012-07-25 10:40 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (26.74 KB, patch)
2012-07-26 06:00 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (26.85 KB, patch)
2012-07-26 06:31 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (26.57 KB, patch)
2012-07-26 06:39 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-07-24 11:01:37 PDT
This attempts to resolve a number of problems with current status bar items management, in particular:
- explicit handling of some panel/view items by generic code in Drawer and inspector.js (in particular, search counters and timeline panel counters)
- a lot of absolute positioned items in status bars, occasionally conflicting with each other and preventing usage of static flow to position other items
- "anchored" status bar items that used to include some icons on the left and counters on the right
Comment 1 Andrey Kosyakov 2012-07-24 11:06:52 PDT
Created attachment 154109 [details]
Patch
Comment 2 Andrey Kosyakov 2012-07-25 09:41:50 PDT
Created attachment 154376 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-07-25 10:03:36 PDT
Comment on attachment 154376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154376&action=review

> Source/WebCore/inspector/front-end/inspector.html:235
> +        <div id="panel-status-bar-placeholder" class="status-bar"><div id="panel-status-bar-resizer"></div></div>

panel-status-bar

> Source/WebCore/inspector/front-end/inspector.html:239
> +        <div id="inner-status-bar">

main-status-bar-inner

> Source/WebCore/inspector/front-end/inspector.html:240
> +            <div id="panel-status-bar"></div>

panel-status-bar-items
Comment 4 Andrey Kosyakov 2012-07-25 10:40:13 PDT
Created attachment 154389 [details]
Patch
Comment 5 Andrey Kosyakov 2012-07-26 06:00:22 PDT
Created attachment 154627 [details]
Patch
Comment 6 Andrey Kosyakov 2012-07-26 06:31:44 PDT
Created attachment 154639 [details]
Patch
Comment 7 Andrey Kosyakov 2012-07-26 06:39:24 PDT
Created attachment 154640 [details]
Patch
Comment 8 Pavel Feldman 2012-07-26 08:32:00 PDT
Comment on attachment 154640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154640&action=review

> Source/WebCore/inspector/front-end/inspector.html:238
> +    <div id="main-status-bar" class="status-bar">

Please move this into the JavaScript.
Comment 9 Andrey Kosyakov 2012-07-26 10:56:06 PDT
Committed r123770: <http://trac.webkit.org/changeset/123770>