RESOLVED WORKSFORME 92140
gnomekeyring support blocks webkit-patch upload in remote ssh session
https://bugs.webkit.org/show_bug.cgi?id=92140
Summary gnomekeyring support blocks webkit-patch upload in remote ssh session
Dana Jansens
Reported 2012-07-24 10:30:49 PDT
% env |grep KEY <empty list> % upload --request-commit 91885 Total errors found: 0 in 10 files Please enter a bug number or a title for a new bug: Fetching: https://bugs.webkit.org/show_bug.cgi?id=91885&ctype=xml Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. Change author: Dana Jansens <danakj@chromium.org>. Editing the Source/WebKit/chromium/ChangeLog file. Editing the Source/WebCore/ChangeLog file. -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- Was that diff correct? [Y/n]: Fetching: https://bugs.webkit.org/show_bug.cgi?id=91885&ctype=xml Obsoleting 1 old patch on bug 91885 Traceback (most recent call last): File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkit-patch", line 69, in <module> main() File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkit-patch", line 64, in main WebKitPatch(os.path.abspath(__file__)).main() File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main result = command.check_arguments_and_execute(options, args, self) File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/tool/steps/obsoletepatches.py", line 51, in run self._tool.bugs.obsolete_attachment(patch.id()) File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 732, in obsolete_attachment self.authenticate() File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 488, in authenticate username, password = credentials.read_credentials() File "/usr/local/google/home/danakj/s/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py", line 146, in read_credentials password = self._keyring.get_password(self.host, username) File "/usr/lib/python2.7/dist-packages/keyring/core.py", line 34, in get_password return _keyring_backend.get_password(service_name, username) File "/usr/lib/python2.7/dist-packages/keyring/backend.py", line 154, in get_password items = gnomekeyring.find_network_password_sync(username, service) gnomekeyring.IOError
Attachments
Patch for testing (566 bytes, patch)
2012-08-06 15:52 PDT, Adam Barth
no flags
Dana Jansens
Comment 1 2012-07-24 10:45:37 PDT
Setting self._keyring to None in the constructor of credentials.py avoid this as a workaround locally for now.
Adam Barth
Comment 2 2012-08-06 15:02:41 PDT
Sorry this has taken a bit. I think it's mostly a matter of catching the exception and not crashing.
Adam Barth
Comment 3 2012-08-06 15:52:33 PDT
Created attachment 156779 [details] Patch for testing
Adam Barth
Comment 4 2012-08-06 15:53:30 PDT
Dana: Does this patch fix this issue for you? I don't fully understand why the existing code isn't catching the gnomekeyring.IOError exception. I thought that Python syntax caught everything.
Dana Jansens
Comment 5 2012-08-22 08:38:58 PDT
Oh! I missed this patch in my vacation email. It seems that upstream is working alright now from my chromebook! So let's close this and I'll reopen if it crops up again somehow.
Note You need to log in before you can comment on or make changes to this bug.