Bug 92114 – Add methods to ColorChooserClient so the color chooser can show suggestions

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Add methods to ColorChooserClient that will be used by the color chooser to show suggestions

[Keishi Hattori]

Created attachment 154056 [details]
Patch

[Kent Tamura]

Comment on attachment 154056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154056&action=review

> Source/WebCore/html/ColorInputType.cpp:215
> +    return element()->fastHasAttribute(HTMLNames::listAttr);

We usually declare "using namespace HTMLNames;" and omit HTMLNames::.

[WebKit Review Bot]

Comment on attachment 154056 [details]
Patch

Attachment 154056 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13338269

[Gyuyoung Kim]

Comment on attachment 154056 [details]
Patch

Attachment 154056 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13326464

[Keishi Hattori]

Created attachment 154065 [details]
Patch

[Keishi Hattori]

Added includes that were missing and made HTMLInputElement::dataList() public

[Kent Tamura]

Comment on attachment 154065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154065&action=review

> Source/WebCore/html/ColorInputType.cpp:231
> +            suggestions.append(Color(option->value()));

We should check Color::isValid() because HTMLOptionElement::value() might have an invalid string.
Also, we shouldn't accept named color like "white".

[Keishi Hattori]

Created attachment 154221 [details]
Patch

[Kent Tamura]

Comment on attachment 154221 [details]
Patch

Looks ok

[WebKit Review Bot]

Comment on attachment 154221 [details]
Patch

Clearing flags on attachment: 154221

Committed r123601: <http://trac.webkit.org/changeset/123601>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.