Bug 92106 - MediaStream API: Remove DeprecatedPeerConnection
Summary: MediaStream API: Remove DeprecatedPeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459 80589
  Show dependency tree / graph
 
Reported: 2012-07-24 05:51 PDT by Tommy Widenflycht
Modified: 2012-07-26 03:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (103.36 KB, patch)
2012-07-24 06:23 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (104.58 KB, patch)
2012-07-24 08:27 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (104.59 KB, patch)
2012-07-26 01:39 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-07-24 05:51:19 PDT 
Since we are getting ready to add an updated PeerConnection the old DeprecatedPeerConnection will have to go.
Comment 1 Tommy Widenflycht 2012-07-24 06:23:46 PDT 
Created attachment 154040 [details]
Patch
Comment 2 Tommy Widenflycht 2012-07-24 06:24:24 PDT 
No code changes, except for deleted code.
Comment 3 Gyuyoung Kim 2012-07-24 07:06:56 PDT 
Comment on attachment 154040 [details]
Patch

Attachment 154040 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13332379
Comment 4 Tommy Widenflycht 2012-07-24 08:27:43 PDT 
Created attachment 154070 [details]
Patch
Comment 5 Adam Barth 2012-07-24 10:48:27 PDT 
Comment on attachment 154070 [details]
Patch

I'm glad we're removing this code.  Let's give Adam a chance to comment in case he has thoughts on this patch.
Comment 6 Tommy Widenflycht 2012-07-26 01:27:09 PDT 
I haven't heard anything so committing.
Comment 7 WebKit Review Bot 2012-07-26 01:28:24 PDT 
Comment on attachment 154070 [details]
Patch

Rejecting attachment 154070 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rm/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt
patching file LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt
patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
patching file LayoutTests/platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13343688
Comment 8 Tommy Widenflycht 2012-07-26 01:39:52 PDT 
Created attachment 154576 [details]
Patch
Comment 9 Tommy Widenflycht 2012-07-26 01:40:34 PDT 
Just rebased to fix build file merge errors.
Comment 10 WebKit Review Bot 2012-07-26 03:34:35 PDT 
Comment on attachment 154576 [details]
Patch

Clearing flags on attachment: 154576

Committed r123724: <http://trac.webkit.org/changeset/123724>
Comment 11 WebKit Review Bot 2012-07-26 03:34:41 PDT 
All reviewed patches have been landed.  Closing bug.