Bug 92102 – [EFL] Get rid of pango backend support once harfbuzz-ng is working

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dominik Röttsches (drott)]

As per http://behdad.org/text/ I think we should get rid of the pango backend once we have harfbuzz-ng support.

[Gyuyoung Kim]

If you wanna stop to support pango backend in EFL port, I think you need to notify this removal to webkit-efl as well.

[Dominik Röttsches (drott)]

Created attachment 159114 [details]
Removing Pango from EFL buildsystem.

[Dominik Röttsches (drott)]

(In reply to comment #2)
> Created an attachment (id=159114) [details]
> Removing Pango from EFL buildsystem.

Since there were no objections on webkit-efl list.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 159114 [details]
Removing Pango from EFL buildsystem.

This is awesome, I love code cleanups. In theory, you can also get rid of LibFindMacros.cmake, as FindPango.cmake was its last user.

[Ryuan Choi]

As I mentioned in webkit-efl mailing list.

I don't have objection for removing.

However, please give me some time for webkit/tizen to catch up trunk.

As I mentioned,
tizen/webkit still use FontPango.cpp and FindPango.cmake

And also, I heard that internal implementation of spellchecker had pango dependency.

If this is not urgent task,
I want to keep this until tizen/webkit solved related issues.

[Dominik Röttsches (drott)]

Created attachment 159351 [details]
Removing Pango from EFL buildsystem, v2. LibFindMacros removed.

[Dominik Röttsches (drott)]

(In reply to comment #5)
> As I mentioned in webkit-efl mailing list.
> I don't have objection for removing.
> However, please give me some time for webkit/tizen to catch up trunk.
> 
> As I mentioned, tizen/webkit still use FontPango.cpp and FindPango.cmake
> If this is not urgent task,
> I want to keep this until tizen/webkit solved related issues.

I think, we should clean this up in upstream quickly. You can keep a local patch for the pieces that you still need. Since there's no other dependency and it's only removing code and files, I think the maintenance overhead for keeping this as a local change is rather small.

[WebKit Review Bot]

Comment on attachment 159351 [details]
Removing Pango from EFL buildsystem, v2. LibFindMacros removed.

Clearing flags on attachment: 159351

Committed r126010: <http://trac.webkit.org/changeset/126010>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.