RESOLVED FIXED 92096
Move PagePopupClient helper functions so they can be shared 
https://bugs.webkit.org/show_bug.cgi?id=92096
Summary Move PagePopupClient helper functions so they can be shared
Keishi Hattori
Reported 2012-07-24 04:30:20 PDT
Move PagePopupClient helper functions so they can be shared
Attachments
Patch (11.15 KB, patch)
2012-07-24 06:06 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (11.05 KB, patch)
2012-07-24 07:04 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-07-24 06:06:15 PDT
Created attachment 154036 [details] Patch
Kent Tamura
Comment 2 2012-07-24 06:53:50 PDT
Comment on attachment 154036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review > Source/WebCore/page/PagePopupClient.h:52 > + // Helper functions to be used in PagePopupClient::writeDocument(). > + static void addString(const String&, DocumentWriter&); > + static void addJavaScriptString(const String&, DocumentWriter&); > + static void addProperty(const char* name, const String& value, DocumentWriter&); > + static void addProperty(const char* name, unsigned value, DocumentWriter&); > + static void addProperty(const char* name, bool value, DocumentWriter&); > + static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&); Please move them to the bottom of the class definition. Pure virtual functions are more important than static helper functions.
Keishi Hattori
Comment 3 2012-07-24 07:04:42 PDT
Created attachment 154050 [details] Patch
Keishi Hattori
Comment 4 2012-07-24 07:07:18 PDT
(In reply to comment #2) > (From update of attachment 154036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review > > > Source/WebCore/page/PagePopupClient.h:52 > > + // Helper functions to be used in PagePopupClient::writeDocument(). > > + static void addString(const String&, DocumentWriter&); > > + static void addJavaScriptString(const String&, DocumentWriter&); > > + static void addProperty(const char* name, const String& value, DocumentWriter&); > > + static void addProperty(const char* name, unsigned value, DocumentWriter&); > > + static void addProperty(const char* name, bool value, DocumentWriter&); > > + static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&); > > Please move them to the bottom of the class definition. Pure virtual functions are more important than static helper functions. Done.
Kent Tamura
Comment 5 2012-07-24 07:21:46 PDT
Comment on attachment 154050 [details] Patch ok
WebKit Review Bot
Comment 6 2012-07-24 19:35:22 PDT
Comment on attachment 154050 [details] Patch Clearing flags on attachment: 154050 Committed r123568: <http://trac.webkit.org/changeset/123568>
WebKit Review Bot
Comment 7 2012-07-24 19:35:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.