Move PagePopupClient helper functions so they can be shared
Created attachment 154036 [details] Patch
Comment on attachment 154036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review > Source/WebCore/page/PagePopupClient.h:52 > + // Helper functions to be used in PagePopupClient::writeDocument(). > + static void addString(const String&, DocumentWriter&); > + static void addJavaScriptString(const String&, DocumentWriter&); > + static void addProperty(const char* name, const String& value, DocumentWriter&); > + static void addProperty(const char* name, unsigned value, DocumentWriter&); > + static void addProperty(const char* name, bool value, DocumentWriter&); > + static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&); Please move them to the bottom of the class definition. Pure virtual functions are more important than static helper functions.
Created attachment 154050 [details] Patch
(In reply to comment #2) > (From update of attachment 154036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review > > > Source/WebCore/page/PagePopupClient.h:52 > > + // Helper functions to be used in PagePopupClient::writeDocument(). > > + static void addString(const String&, DocumentWriter&); > > + static void addJavaScriptString(const String&, DocumentWriter&); > > + static void addProperty(const char* name, const String& value, DocumentWriter&); > > + static void addProperty(const char* name, unsigned value, DocumentWriter&); > > + static void addProperty(const char* name, bool value, DocumentWriter&); > > + static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&); > > Please move them to the bottom of the class definition. Pure virtual functions are more important than static helper functions. Done.
Comment on attachment 154050 [details] Patch ok
Comment on attachment 154050 [details] Patch Clearing flags on attachment: 154050 Committed r123568: <http://trac.webkit.org/changeset/123568>
All reviewed patches have been landed. Closing bug.