Bug 92096 - Move PagePopupClient helper functions so they can be shared
Summary: Move PagePopupClient helper functions so they can be shared
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 92075
  Show dependency treegraph
 
Reported: 2012-07-24 04:30 PDT by Keishi Hattori
Modified: 2012-07-24 19:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.15 KB, patch)
2012-07-24 06:06 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (11.05 KB, patch)
2012-07-24 07:04 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-07-24 04:30:20 PDT
Move PagePopupClient helper functions so they can be shared
Comment 1 Keishi Hattori 2012-07-24 06:06:15 PDT
Created attachment 154036 [details]
Patch
Comment 2 Kent Tamura 2012-07-24 06:53:50 PDT
Comment on attachment 154036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review

> Source/WebCore/page/PagePopupClient.h:52
> +    // Helper functions to be used in PagePopupClient::writeDocument().
> +    static void addString(const String&, DocumentWriter&);
> +    static void addJavaScriptString(const String&, DocumentWriter&);
> +    static void addProperty(const char* name, const String& value, DocumentWriter&);
> +    static void addProperty(const char* name, unsigned value, DocumentWriter&);
> +    static void addProperty(const char* name, bool value, DocumentWriter&);
> +    static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&);

Please move them to the bottom of the class definition.  Pure virtual functions are more important than static helper functions.
Comment 3 Keishi Hattori 2012-07-24 07:04:42 PDT
Created attachment 154050 [details]
Patch
Comment 4 Keishi Hattori 2012-07-24 07:07:18 PDT
(In reply to comment #2)
> (From update of attachment 154036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review
> 
> > Source/WebCore/page/PagePopupClient.h:52
> > +    // Helper functions to be used in PagePopupClient::writeDocument().
> > +    static void addString(const String&, DocumentWriter&);
> > +    static void addJavaScriptString(const String&, DocumentWriter&);
> > +    static void addProperty(const char* name, const String& value, DocumentWriter&);
> > +    static void addProperty(const char* name, unsigned value, DocumentWriter&);
> > +    static void addProperty(const char* name, bool value, DocumentWriter&);
> > +    static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&);
> 
> Please move them to the bottom of the class definition.  Pure virtual functions are more important than static helper functions.

Done.
Comment 5 Kent Tamura 2012-07-24 07:21:46 PDT
Comment on attachment 154050 [details]
Patch

ok
Comment 6 WebKit Review Bot 2012-07-24 19:35:22 PDT
Comment on attachment 154050 [details]
Patch

Clearing flags on attachment: 154050

Committed r123568: <http://trac.webkit.org/changeset/123568>
Comment 7 WebKit Review Bot 2012-07-24 19:35:25 PDT
All reviewed patches have been landed.  Closing bug.