[WTR][EFL] Wheel events are not emitted

[Alexander Shalamov]

Mouse wheel events are not emitted when fired from EventSenderProxy

[Alexander Shalamov]

Created attachment 154014 [details]
Patch

Fix for wheel event.

[Chris Dumez]

Comment on attachment 154014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154014&action=review

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:144
> +static void dispatchMouseDownEvent(Evas* evas, unsigned button, WKEventModifiers wkModifiers, int clickCount)

Looks unrelated to this bug. Maybe it should be in a separate patch?

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:304
> +        dispatchMouseDownEvent(ecore_evas_get(m_testController->mainWebView()->platformWindow()), event.button, event.modifiers, m_clickCount);

Ditto.

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:53
> +    evas_object_show(m_view);

Ditto.

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:74
> +    evas_object_focus_set(m_view, EINA_TRUE);

Ditto.

[Alexander Shalamov]

Created attachment 154024 [details]
Patch

Removed click related code.

[Alexander Shalamov]

(In reply to comment #2)
> (From update of attachment 154014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154014&action=review
> 
> > Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:144
> > +static void dispatchMouseDownEvent(Evas* evas, unsigned button, WKEventModifiers wkModifiers, int clickCount)
> 
> Looks unrelated to this bug. Maybe it should be in a separate patch?

Removed, will file new bug

> > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:53
> > +    evas_object_show(m_view);
> 
> Ditto.
> 
> > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:74
> > +    evas_object_focus_set(m_view, EINA_TRUE);
> 
> Ditto.
Those are required. View should not be hidden and should be focused, otherwise wheel events are not received in ewk view.

[Chris Dumez]

Comment on attachment 154024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154024&action=review

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:361
> +    event.horizontal = -(horizontal);

Why the brackets?

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:362
> +    event.vertical = -(vertical);

Ditto.

[Chris Dumez]

Comment on attachment 154024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154024&action=review

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:74
> +    evas_object_focus_set(m_view, EINA_TRUE);

This is a cpp file, please use true instead of EINA_TRUE.

[Chris Dumez]

Comment on attachment 154024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154024&action=review

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:-371
> -    event.vertical = vertical;

It might be worth adding a comment to explain why we need to reverse the values.

[Alexander Shalamov]

Created attachment 154026 [details]
Patch

Applied fixed according to review comments

[Chris Dumez]

Comment on attachment 154026 [details]
Patch

LGTM.

[Csaba Osztrogonác]

Comment on attachment 154026 [details]
Patch

rs=me based on informal review.

[WebKit Review Bot]

Comment on attachment 154026 [details]
Patch

Clearing flags on attachment: 154026

Committed r123599: <http://trac.webkit.org/changeset/123599>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.