Bug 92092 - [Chromium] Page popup should close on mouse down
Summary: [Chromium] Page popup should close on mouse down
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on: 92110
Blocks: 92075
  Show dependency treegraph
 
Reported: 2012-07-24 03:26 PDT by Keishi Hattori
Modified: 2012-07-24 08:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.53 KB, patch)
2012-07-24 03:49 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2012-07-24 06:49 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-07-24 03:26:34 PDT
Page popup should close on mouse down.
Comment 1 Keishi Hattori 2012-07-24 03:49:30 PDT
Created attachment 154010 [details]
Patch
Comment 2 Kent Tamura 2012-07-24 03:53:07 PDT
Comment on attachment 154010 [details]
Patch

Looks good.
Comment 3 WebKit Review Bot 2012-07-24 05:38:23 PDT
Comment on attachment 154010 [details]
Patch

Clearing flags on attachment: 154010

Committed r123463: <http://trac.webkit.org/changeset/123463>
Comment 4 WebKit Review Bot 2012-07-24 05:38:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-07-24 06:21:45 PDT
Re-opened since this is blocked by 92110
Comment 6 Keishi Hattori 2012-07-24 06:49:33 PDT
Created attachment 154046 [details]
Patch
Comment 7 Keishi Hattori 2012-07-24 06:50:18 PDT
Broke the android build because I forgot #if ENABLE(PAGE_POPUP)
Comment 8 WebKit Review Bot 2012-07-24 08:31:50 PDT
Comment on attachment 154046 [details]
Patch

Clearing flags on attachment: 154046

Committed r123479: <http://trac.webkit.org/changeset/123479>
Comment 9 WebKit Review Bot 2012-07-24 08:31:54 PDT
All reviewed patches have been landed.  Closing bug.