Bug 92074 – Missing *explicit* keyword in dom and page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

Some constructors missed to use *explicit* keyword. They need to be added *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion. Some files in dom directory can't use explicit keyword because of build breaks.

[Gyuyoung Kim]

Created attachment 153979 [details]
Patch

[Kentaro Hara]

Comment on attachment 153979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153979&action=review

Looks OK.

> Source/WebCore/ChangeLog:12
> +        Some files in dom directory can't use explicit keyword because of build breaks.

Some constructors are not explicit to allow type conversion intentionally. Please keep watching the tree not to break something.

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 153979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153979&action=review
> 
> Looks OK.
> 
> > Source/WebCore/ChangeLog:12
> > +        Some files in dom directory can't use explicit keyword because of build breaks.
> 
> Some constructors are not explicit to allow type conversion intentionally. Please keep watching the tree not to break something.

Yes, I will check if there are build breaks on all ports.

[Gyuyoung Kim]

Comment on attachment 153979 [details]
Patch

I'm sure GTK port also will not have build break.

[WebKit Review Bot]

Comment on attachment 153979 [details]
Patch

Clearing flags on attachment: 153979

Committed r123451: <http://trac.webkit.org/changeset/123451>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.