This is a follow-up of bug 15365. I misread the specification and allowed any inline formatting context to generate an inline-table wrapper. CSS 2.1 just takes the display into account: "If C's parent is an 'inline' box, then T must be an 'inline-table' box; otherwise it must be a 'table' box." (C is a proper table child) Patch forthcoming.
Created attachment 154079 [details] Trivial patch.
Comment on attachment 154079 [details] Trivial patch. View in context: https://bugs.webkit.org/attachment.cgi?id=154079&action=review > Source/WebCore/ChangeLog:3 > + inline-table wrapper should be generated for display: inline element only Please add Regression(rXYZ): > LayoutTests/fast/table/inline-block-generates-table-wrapper-expected.html:9 > + display: table-cell; Is this display table ? in this expected testcase, we can even directly use the table and td tags.
Comment on attachment 154079 [details] Trivial patch. View in context: https://bugs.webkit.org/attachment.cgi?id=154079&action=review >> Source/WebCore/ChangeLog:3 >> + inline-table wrapper should be generated for display: inline element only > > Please add Regression(rXYZ): It's not really a regression. The code was actually working due to another bug: we didn't check for table parts in RenderBlock::addChildIgnoringContinuation and thus would wrap table parts in an anonymous block, leading to the right behavior. This was confusing which is why I sided with fixing our check to match what the spec said. >> LayoutTests/fast/table/inline-block-generates-table-wrapper-expected.html:9 >> + display: table-cell; > > Is this display table ? in this expected testcase, we can even directly use the table and td tags. Good catch, it should be display: table or the test case is void. Using <td> or <table> is a not-so-great-an-idea due to the UA style sheet and the different behaviors between CSS and HTML tables. It's better to stick with CSS tables for consistency.
Created attachment 154091 [details] Patch for landing
Comment on attachment 154091 [details] Patch for landing Clearing flags on attachment: 154091 Committed r123492: <http://trac.webkit.org/changeset/123492>
All reviewed patches have been landed. Closing bug.