Bug 92052 – Fix regressions in replay performance tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

Fix regressions in replay performance tests

[Ryosuke Niwa]

Created attachment 153931 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153931 [details]
Patch

Attachment 153931 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13325300

New failing tests:
fast/ruby/generated-before-counter-doesnt-crash.html
fast/loader/null-request-after-willSendRequest.html
fast/css-generated-content/malformed-url.html
fast/ruby/before-table-doesnt-crash.html
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
fast/ruby/before-block-doesnt-crash.html

[WebKit Review Bot]

Created attachment 153945 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Ryosuke Niwa]

Created attachment 153953 [details]
Patch

[Dirk Pranke]

Comment on attachment 153953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153953&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:198
> +        self.assertEqual(port.host.filesystem.files['/path/some-dir/some-test-actual.png'], 'actual image')

I try to keep clients of the mock filesystem from actually accessing files; it should probably be _files instead. Can you change this to filesystem.read_binary_file()?

> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:285
> +        self.assertEqual(port.host.filesystem.files['/path/some-dir/some-test-expected.png'], 'actual image')

same thing ...

[Ryosuke Niwa]

Comment on attachment 153953 [details]
Patch

Thanks for the review. Landing the patch after addressing the comments.

[Ryosuke Niwa]

Committed r123498: <http://trac.webkit.org/changeset/123498>