Bug 92051 - run-perf-tests --build-directory doesn't work
Summary: run-perf-tests --build-directory doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-07-23 18:01 PDT by Stephanie Lewis
Modified: 2012-09-13 14:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2012-08-01 09:35 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2012-07-23 18:01:00 PDT 
It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build.  Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs.
Comment 1 Zoltan Horvath 2012-08-01 04:04:40 PDT 
(In reply to comment #0)
> It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build.  Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs.

It makes sense. On Qt-port run-perf-tests --build-directory ... doesn't work for me. Can you verify that is working for you?
Comment 2 Ryosuke Niwa 2012-08-01 09:35:50 PDT 
Created attachment 155821 [details]
Patch
Comment 3 Ryosuke Niwa 2012-08-01 09:36:34 PDT 
This was a mind-blowingly silly bug.
Comment 4 Ryosuke Niwa 2012-08-01 10:22:14 PDT 
It might make sense for --no-build to automatically turn on when --build-directory is specified. Otherwise we'll just fail after trying to build DRT.
Comment 5 Ryosuke Niwa 2012-08-01 14:03:03 PDT 
Committed r124366: <http://trac.webkit.org/changeset/124366>