Bug 92030 - [chromium] Fix unit tests in debug mode after r123375
Summary: [chromium] Fix unit tests in debug mode after r123375
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-23 14:47 PDT by Shawn Singh
Modified: 2012-07-23 16:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2012-07-23 14:55 PDT, Shawn Singh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2012-07-23 14:47:38 PDT 
A few unit tests were triggering assertions because of the refactoring done in r123375.   That revision added an assertion to make sure that the root layer is not empty when given to calcDrawTransforms -- there is no reason to believe this assertion is too aggressive, and its good that it triggers.   Patch coming in a moment that fixes the unit tests that trigger the assertion, they now use a non-zero size for the root layer.
Comment 1 Shawn Singh 2012-07-23 14:55:13 PDT 
Created attachment 153868 [details]
Patch
Comment 2 Shawn Singh 2012-07-23 14:59:46 PDT 
I supposed it would help to CC a reviewer =)
Comment 3 Adrienne Walker 2012-07-23 15:22:41 PDT 
Comment on attachment 153868 [details]
Patch

R=me.
Comment 4 WebKit Review Bot 2012-07-23 16:06:33 PDT 
Comment on attachment 153868 [details]
Patch

Clearing flags on attachment: 153868

Committed r123398: <http://trac.webkit.org/changeset/123398>
Comment 5 WebKit Review Bot 2012-07-23 16:06:37 PDT 
All reviewed patches have been landed.  Closing bug.