Bug 91993 – [Qt] editing/inserting/multiple-lines-selected.html fails

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Caio Marcelo de Oliveira Filho]

The test editing/inserting/multiple-lines-selected.html is failing in both DRT and WTR. It is expected that both "oo" and "b" are removed when the new paragraph is added, but "b" remains in the text.

The test works correctly when run in QtTestBrowser and MiniBrowser.

[Caio Marcelo de Oliveira Filho]

Created attachment 153791 [details]
Remove wrong expected results and skip the test.

[Simon Hausmann]

Comment on attachment 153791 [details]
Remove wrong expected results and skip the test.

rs=me

[Caio Marcelo de Oliveira Filho]

Committed r123336: <http://trac.webkit.org/changeset/123336>

[Lauro Moura Maranhao Neto]

WTR/DRT/testfonts are using the system default hinting strategy (at least not setting it explicitly). When forcing full hinting in FontPlatformData, the same f/bar result is acheived with MiniBrowser, and even with a plain QTextEdit. Such results seems to be expected as the width of 'f' gets smaller when using full hinting.

In the long run the correct option IMHO would be setting the hinting explicitly to get consistent results. But setting it to None would require another big rebaseline. Just in LayoutTests/editing/ this change made 500 tests fail out of 1200.

PS: GTK disables system default hinting to ensure the results are consistent.

[Caio Marcelo de Oliveira Filho]

(In reply to comment #4)
> In the long run the correct option IMHO would be setting the hinting explicitly to get consistent results. But setting it to None would require another big rebaseline. Just in LayoutTests/editing/ this change made 500 tests fail out of 1200.

Question: what hint setting would match our existing test expectations? I think we should enforce it in our testing infrastructure.

[Lauro Moura Maranhao Neto]

(In reply to comment #5)
> (In reply to comment #4)
> > In the long run the correct option IMHO would be setting the hinting explicitly to get consistent results. But setting it to None would require another big rebaseline. Just in LayoutTests/editing/ this change made 500 tests fail out of 1200.
> 
> Question: what hint setting would match our existing test expectations? I think we should enforce it in our testing infrastructure.

Current test expectations seem to have been generated with full hinting (Ubuntu 11.10 default here), which yields similar results to light hinting. But QFontConfigDatabase::fontEngine() sets the hinting to full if no predefined hint is set in font config font match.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.