Bug 91992 - [BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
Summary: [BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-23 06:51 PDT by Arvid Nilsson
Modified: 2012-07-25 07:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.74 KB, patch)
2012-07-24 05:58 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (2.32 KB, patch)
2012-07-24 06:02 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2012-07-25 07:19 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-07-23 06:51:01 PDT
The copyPreviousContentsToBackSurfaceOfTile() call will also modify buffer contents, move it after the blit generation condvar to make sure the GPU is done with it before modifying the buffer.
Comment 1 Arvid Nilsson 2012-07-24 05:58:29 PDT
Created attachment 154033 [details]
Patch
Comment 2 Arvid Nilsson 2012-07-24 06:00:14 PDT
Hmm, looking at the patch again, it doesn't make sense to move the call that gets the buffer pointer, because the whole condvar business could be replaced by a method that takes the buffer pointer and performs the synchronization to encapsulate the mechanism.
Comment 3 Arvid Nilsson 2012-07-24 06:02:46 PDT
Created attachment 154035 [details]
Patch
Comment 4 Arvid Nilsson 2012-07-24 06:03:25 PDT
This is a pretty minimal patch =)

Internally reviewed by Jakob Petsovits, what do you think?
Comment 5 WebKit Review Bot 2012-07-25 06:27:20 PDT
Comment on attachment 154035 [details]
Patch

Rejecting attachment 154035 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13345220
Comment 6 Arvid Nilsson 2012-07-25 07:13:21 PDT
OOPS, I said OOPS in the Changelog!
Comment 7 Arvid Nilsson 2012-07-25 07:19:47 PDT
Created attachment 154348 [details]
Patch
Comment 8 Arvid Nilsson 2012-07-25 07:20:41 PDT
Comment on attachment 154348 [details]
Patch

Same patch, this time without OOPS. If I understand correctly, only CQ+ is needed now, since it's already reviewied before.
Comment 9 WebKit Review Bot 2012-07-25 07:59:55 PDT
Comment on attachment 154348 [details]
Patch

Clearing flags on attachment: 154348

Committed r123617: <http://trac.webkit.org/changeset/123617>
Comment 10 WebKit Review Bot 2012-07-25 07:59:59 PDT
All reviewed patches have been landed.  Closing bug.