RESOLVED FIXED 91992
[BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU 
https://bugs.webkit.org/show_bug.cgi?id=91992
Summary [BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
Arvid Nilsson
Reported 2012-07-23 06:51:01 PDT
The copyPreviousContentsToBackSurfaceOfTile() call will also modify buffer contents, move it after the blit generation condvar to make sure the GPU is done with it before modifying the buffer.
Attachments
Patch (2.74 KB, patch)
2012-07-24 05:58 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2012-07-24 06:02 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2012-07-25 07:19 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-07-24 05:58:29 PDT
Created attachment 154033 [details] Patch
Arvid Nilsson
Comment 2 2012-07-24 06:00:14 PDT
Hmm, looking at the patch again, it doesn't make sense to move the call that gets the buffer pointer, because the whole condvar business could be replaced by a method that takes the buffer pointer and performs the synchronization to encapsulate the mechanism.
Arvid Nilsson
Comment 3 2012-07-24 06:02:46 PDT
Created attachment 154035 [details] Patch
Arvid Nilsson
Comment 4 2012-07-24 06:03:25 PDT
This is a pretty minimal patch =) Internally reviewed by Jakob Petsovits, what do you think?
WebKit Review Bot
Comment 5 2012-07-25 06:27:20 PDT
Comment on attachment 154035 [details] Patch Rejecting attachment 154035 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13345220
Arvid Nilsson
Comment 6 2012-07-25 07:13:21 PDT
OOPS, I said OOPS in the Changelog!
Arvid Nilsson
Comment 7 2012-07-25 07:19:47 PDT
Created attachment 154348 [details] Patch
Arvid Nilsson
Comment 8 2012-07-25 07:20:41 PDT
Comment on attachment 154348 [details] Patch Same patch, this time without OOPS. If I understand correctly, only CQ+ is needed now, since it's already reviewied before.
WebKit Review Bot
Comment 9 2012-07-25 07:59:55 PDT
Comment on attachment 154348 [details] Patch Clearing flags on attachment: 154348 Committed r123617: <http://trac.webkit.org/changeset/123617>
WebKit Review Bot
Comment 10 2012-07-25 07:59:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.